From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUN1Z-0000kW-Nl for qemu-devel@nongnu.org; Sat, 07 Mar 2015 17:16:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUN1W-0002Nd-E6 for qemu-devel@nongnu.org; Sat, 07 Mar 2015 17:16:45 -0500 From: Stefan Weil Date: Sat, 7 Mar 2015 23:16:38 +0100 Message-Id: <1425766598-18297-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH] target-ppc: Fix warnings from Sparse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Trivial Cc: Stefan Weil , QEMU Developer , Alexander Graf Sparse report: target-ppc/mmu-hash64.c:353:9: warning: returning void-valued expression target-ppc/mmu-hash64.c:620:9: warning: returning void-valued expression Cc: Alexander Graf Signed-off-by: Stefan Weil --- Should we fix this kind of warnings? QEMU includes more than 60 lines of code which return a void expression. Stefan target-ppc/mmu-hash64.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target-ppc/mmu-hash64.c b/target-ppc/mmu-hash64.c index b0278c9..a9e1b4c 100644 --- a/target-ppc/mmu-hash64.c +++ b/target-ppc/mmu-hash64.c @@ -350,7 +350,7 @@ uint64_t ppc_hash64_start_access(PowerPCCPU *cpu, target_ulong pte_index) void ppc_hash64_stop_access(uint64_t token) { if (kvmppc_kern_htab) { - return kvmppc_hash64_free_pteg(token); + kvmppc_hash64_free_pteg(token); } } @@ -617,7 +617,8 @@ void ppc_hash64_store_hpte(CPUPPCState *env, CPUState *cs = CPU(ppc_env_get_cpu(env)); if (kvmppc_kern_htab) { - return kvmppc_hash64_write_pte(env, pte_index, pte0, pte1); + kvmppc_hash64_write_pte(env, pte_index, pte0, pte1); + return; } pte_index *= HASH_PTE_SIZE_64; -- 2.1.4