From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUWpg-0004a0-Dn for qemu-devel@nongnu.org; Sun, 08 Mar 2015 04:45:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUWpb-0004i9-Ag for qemu-devel@nongnu.org; Sun, 08 Mar 2015 04:45:08 -0400 From: Alexander Graf Date: Sun, 8 Mar 2015 09:44:38 +0100 Message-Id: <1425804297-53727-20-git-send-email-agraf@suse.de> In-Reply-To: <1425804297-53727-1-git-send-email-agraf@suse.de> References: <1425804297-53727-1-git-send-email-agraf@suse.de> Subject: [Qemu-devel] [PULL 19/38] Openpic: check that cpu id is within the number of cpus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-ppc@nongnu.org Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, Fabien Chouteau From: Fabien Chouteau Signed-off-by: Fabien Chouteau Signed-off-by: Alexander Graf --- hw/intc/openpic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/intc/openpic.c b/hw/intc/openpic.c index 7d1f3b9..305377d 100644 --- a/hw/intc/openpic.c +++ b/hw/intc/openpic.c @@ -1013,7 +1013,7 @@ static void openpic_cpu_write_internal(void *opaque, hwaddr addr, DPRINTF("%s: cpu %d addr %#" HWADDR_PRIx " <= 0x%08x\n", __func__, idx, addr, val); - if (idx < 0) { + if (idx < 0 || idx >= opp->nb_cpus) { return; } @@ -1152,7 +1152,7 @@ static uint32_t openpic_cpu_read_internal(void *opaque, hwaddr addr, DPRINTF("%s: cpu %d addr %#" HWADDR_PRIx "\n", __func__, idx, addr); retval = 0xFFFFFFFF; - if (idx < 0) { + if (idx < 0 || idx >= opp->nb_cpus) { return retval; } -- 1.8.1.4