From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: qemu-devel@nongnu.org
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>,
quintela@redhat.com, armbru@redhat.com, lcapitulino@redhat.com,
amit.shah@redhat.com, peter.huangpeng@huawei.com,
dgilbert@redhat.com
Subject: [Qemu-devel] [PATCH v4 0/4] Convert 'status' of MigrationInfo from open-coded 'str' to enum type
Date: Mon, 9 Mar 2015 14:45:39 +0800 [thread overview]
Message-ID: <1425883543-8852-1-git-send-email-zhang.zhanghailiang@huawei.com> (raw)
Hi,
This series converts open-coded 'str' type to enum type for 'status'.
This conversion will be more convenient for future extensibility.
Actually, I will add a MIG_STATE_COLO state for COLO, and i also
saw Dave added MIG_STATE_POSTCOPY_ACTIVE for postcopy.
Patch 1 and 2 are preparation for the conversion, patch 3 completes the conversion.
Besides, i add a additional patch (patch 4) to expose 'cancelling' to user,
it will influence libvirt side. And i have CC libvirt development.
One more thing, i have to replace MIG_STATE_ERROR with MIGRATION_STATUS_FAILED,
and it begin from 0, not its original -1. I think it has no side effect.
Please review.
v4:
- Rename _ERROR to _FAILED in patch 1 instead of patch 4 (Eric)
- Add Reviewd-by for patch 2 and 4
- Fix some grammar in commit message of patch 4 (Eric)
v3:
- Use longer name for Migration status macro. (Eric Blake)
- Rename internal-only typename 'MigrationStatus' (Eric, Dave, Markus)
- Expose 'cancelling' state (Eric Blake)
v2:
- Remove '(since xyz)' strings. (Eric Blake)
Thanks for their comments. ;)
zhanghailiang (4):
migration: Rename abbreviated macro MIG_STATE_* to
MIGRATION_STATUS_*
hmp: Rename 'MigrationStatus' to 'HMPMigrationStatus'
migration: Convert 'status' of MigrationInfo to use an enum type
migration: Expose 'cancelling' status to user
hmp.c | 15 ++++----
migration/migration.c | 95 ++++++++++++++++++++++++---------------------------
qapi-schema.json | 34 +++++++++++++++---
3 files changed, 81 insertions(+), 63 deletions(-)
--
1.7.12.4
next reply other threads:[~2015-03-09 6:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 6:45 zhanghailiang [this message]
2015-03-09 6:45 ` [Qemu-devel] [PATCH v4 1/4] migration: Rename abbreviated macro MIG_STATE_* to MIGRATION_STATUS_* zhanghailiang
2015-03-12 19:29 ` Eric Blake
2015-03-09 6:45 ` [Qemu-devel] [PATCH v4 2/4] hmp: Rename 'MigrationStatus' to 'HMPMigrationStatus' zhanghailiang
2015-03-09 6:45 ` [Qemu-devel] [PATCH v4 3/4] migration: Convert 'status' of MigrationInfo to use an enum type zhanghailiang
2015-03-12 19:37 ` Eric Blake
2015-03-13 6:23 ` zhanghailiang
2015-03-09 6:45 ` [Qemu-devel] [PATCH v4 4/4] migration: Expose 'cancelling' status to user zhanghailiang
2015-03-13 10:49 ` Paolo Bonzini
2015-03-13 12:25 ` Eric Blake
2015-03-13 12:28 ` Dr. David Alan Gilbert
2015-03-13 13:10 ` Eric Blake
2015-03-12 1:06 ` [Qemu-devel] [PATCH v4 0/4] Convert 'status' of MigrationInfo from open-coded 'str' to enum type zhanghailiang
2015-03-12 19:30 ` [Qemu-devel] [for 2.3? PATCH " Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425883543-8852-1-git-send-email-zhang.zhanghailiang@huawei.com \
--to=zhang.zhanghailiang@huawei.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).