From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUrT5-00078r-MY for qemu-devel@nongnu.org; Mon, 09 Mar 2015 02:47:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUrT0-0005kx-78 for qemu-devel@nongnu.org; Mon, 09 Mar 2015 02:47:11 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:52770) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUrSz-0005je-CA for qemu-devel@nongnu.org; Mon, 09 Mar 2015 02:47:06 -0400 From: zhanghailiang Date: Mon, 9 Mar 2015 14:45:39 +0800 Message-ID: <1425883543-8852-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH v4 0/4] Convert 'status' of MigrationInfo from open-coded 'str' to enum type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: zhanghailiang , quintela@redhat.com, armbru@redhat.com, lcapitulino@redhat.com, amit.shah@redhat.com, peter.huangpeng@huawei.com, dgilbert@redhat.com Hi, This series converts open-coded 'str' type to enum type for 'status'. This conversion will be more convenient for future extensibility. Actually, I will add a MIG_STATE_COLO state for COLO, and i also saw Dave added MIG_STATE_POSTCOPY_ACTIVE for postcopy. Patch 1 and 2 are preparation for the conversion, patch 3 completes the conversion. Besides, i add a additional patch (patch 4) to expose 'cancelling' to user, it will influence libvirt side. And i have CC libvirt development. One more thing, i have to replace MIG_STATE_ERROR with MIGRATION_STATUS_FAILED, and it begin from 0, not its original -1. I think it has no side effect. Please review. v4: - Rename _ERROR to _FAILED in patch 1 instead of patch 4 (Eric) - Add Reviewd-by for patch 2 and 4 - Fix some grammar in commit message of patch 4 (Eric) v3: - Use longer name for Migration status macro. (Eric Blake) - Rename internal-only typename 'MigrationStatus' (Eric, Dave, Markus) - Expose 'cancelling' state (Eric Blake) v2: - Remove '(since xyz)' strings. (Eric Blake) Thanks for their comments. ;) zhanghailiang (4): migration: Rename abbreviated macro MIG_STATE_* to MIGRATION_STATUS_* hmp: Rename 'MigrationStatus' to 'HMPMigrationStatus' migration: Convert 'status' of MigrationInfo to use an enum type migration: Expose 'cancelling' status to user hmp.c | 15 ++++---- migration/migration.c | 95 ++++++++++++++++++++++++--------------------------- qapi-schema.json | 34 +++++++++++++++--- 3 files changed, 81 insertions(+), 63 deletions(-) -- 1.7.12.4