From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUsMc-0006yY-En for qemu-devel@nongnu.org; Mon, 09 Mar 2015 03:44:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUsMb-0000PN-7h for qemu-devel@nongnu.org; Mon, 09 Mar 2015 03:44:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUsMa-0000PE-VJ for qemu-devel@nongnu.org; Mon, 09 Mar 2015 03:44:33 -0400 Date: Mon, 09 Mar 2015 15:13:54 +0800 From: Jason Wang Message-Id: <1425885234.7734.2@smtp.corp.redhat.com> In-Reply-To: <20150306131347.656ed8c4.cornelia.huck@de.ibm.com> References: <1425534531-6305-1-git-send-email-jasowang@redhat.com> <1425534531-6305-5-git-send-email-jasowang@redhat.com> <20150306131347.656ed8c4.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Subject: Re: [Qemu-devel] [PATCH V3 04/14] virtio-ccw: introduce ccw specific queue limit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Christian Borntraeger , Alexander Graf , qemu-devel@nongnu.org, Richard Henderson On Fri, Mar 6, 2015 at 8:13 PM, Cornelia Huck wrote: > On Thu, 5 Mar 2015 13:48:41 +0800 > Jason Wang wrote: > >> Instead of depending on marco, using a bus specific limit. >> >> Cc: Alexander Graf >> Cc: Cornelia Huck >> Cc: Christian Borntraeger >> Cc: Richard Henderson >> Signed-off-by: Jason Wang >> --- >> hw/s390x/s390-virtio-ccw.c | 7 +++++-- >> hw/s390x/virtio-ccw.c | 13 +++++++------ >> include/hw/s390x/s390_flic.h | 2 +- >> include/hw/virtio/virtio.h | 1 + >> 4 files changed, 14 insertions(+), 9 deletions(-) >> > >> diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c >> index 4874622..98a1a90 100644 >> --- a/hw/s390x/virtio-ccw.c >> +++ b/hw/s390x/virtio-ccw.c > >> @@ -1026,7 +1027,7 @@ static void virtio_ccw_notify(DeviceState *d, >> uint16_t vector) > Unfortunately just snipped off in this diff, but the code says > > if (vector >= 128) { >> return; >> } > > This is originating from (64 bits for queues + 64 bits for secondary > indicators) - only the first bit of secondary indicators is currently > used (for configuration changes). I'd suggest to change that to > queue_max + 64 and add a comment /* queue indicators + secondary > indicators */ or so. Will do this. Thanks