From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 72/73] iotests: add O_DIRECT alignment probing test
Date: Mon, 9 Mar 2015 16:41:57 +0100 [thread overview]
Message-ID: <1425915718-25138-13-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1425915718-25138-1-git-send-email-kwolf@redhat.com>
From: Stefan Hajnoczi <stefanha@redhat.com>
This test case checks that image files can be opened even if I/O
produces EIO errors. QEMU should not refuse opening failed disks since
the guest may be configured for multipath I/O where accessing failed
disks is expected.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
tests/qemu-iotests/128 | 82 ++++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/128.out | 5 +++
tests/qemu-iotests/group | 1 +
3 files changed, 88 insertions(+)
create mode 100755 tests/qemu-iotests/128
create mode 100644 tests/qemu-iotests/128.out
diff --git a/tests/qemu-iotests/128 b/tests/qemu-iotests/128
new file mode 100755
index 0000000..249a865
--- /dev/null
+++ b/tests/qemu-iotests/128
@@ -0,0 +1,82 @@
+#!/bin/bash
+#
+# Test that opening O_DIRECT succeeds when image file I/O produces EIO
+#
+# Copyright (C) 2015 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+#
+
+# creator
+owner=stefanha@redhat.com
+
+seq=`basename $0`
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+
+devname="eiodev$$"
+
+_setup_eiodev()
+{
+ # This test should either be run as root or with passwordless sudo
+ for cmd in "" "sudo -n"; do
+ echo "0 $((1024 * 1024 * 1024 / 512)) error" | \
+ $cmd dmsetup create "$devname" 2>/dev/null
+ if [ "$?" -eq 0 ]; then
+ return
+ fi
+ done
+ _notrun "root privileges required to run dmsetup"
+}
+
+_cleanup_eiodev()
+{
+ for cmd in "" "sudo -n"; do
+ $cmd dmsetup remove "$devname" 2>/dev/null
+ if [ "$?" -eq 0 ]; then
+ return
+ fi
+ done
+}
+
+_cleanup()
+{
+ _cleanup_eiodev
+}
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+# get standard environment, filters and checks
+. ./common.rc
+. ./common.filter
+
+_supported_fmt raw
+_supported_proto file
+_supported_os Linux
+
+_setup_eiodev
+
+TEST_IMG="/dev/mapper/$devname"
+
+echo
+echo "== reading from error device =="
+# Opening image should succeed but the read operation should fail
+$QEMU_IO --format "$IMGFMT" --nocache -c "read 0 65536" "$TEST_IMG" | _filter_qemu_io
+
+# success, all done
+echo "*** done"
+rm -f $seq.full
+status=0
diff --git a/tests/qemu-iotests/128.out b/tests/qemu-iotests/128.out
new file mode 100644
index 0000000..4e43f5f
--- /dev/null
+++ b/tests/qemu-iotests/128.out
@@ -0,0 +1,5 @@
+QA output created by 128
+
+== reading from error device ==
+read failed: Input/output error
+*** done
diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
index 87eec39..71f19d4 100644
--- a/tests/qemu-iotests/group
+++ b/tests/qemu-iotests/group
@@ -121,3 +121,4 @@
114 rw auto quick
116 rw auto quick
123 rw auto quick
+128 rw auto quick
--
1.8.3.1
next prev parent reply other threads:[~2015-03-09 15:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 15:41 [Qemu-devel] [PULL 00/73] Block patches Kevin Wolf
2015-03-09 15:41 ` [Qemu-devel] [PULL 22/73] qcow2: Helper function for refcount modification Kevin Wolf
2015-03-09 15:41 ` [Qemu-devel] [PULL 62/73] virtio-blk: Remove the stale FIXME comment Kevin Wolf
2015-03-09 15:41 ` [Qemu-devel] [PULL 63/73] iotests: Fix 051's reference output Kevin Wolf
2015-03-09 15:41 ` [Qemu-devel] [PULL 64/73] iotests: Remove 006 Kevin Wolf
2015-03-09 15:41 ` [Qemu-devel] [PULL 65/73] iotests: Drop vpc from 004's and 104's format list Kevin Wolf
2015-03-09 15:41 ` [Qemu-devel] [PULL 66/73] block/vdi: Add locking for parallel requests Kevin Wolf
2015-03-09 15:41 ` [Qemu-devel] [PULL 67/73] scsi-hd: fix property unset case Kevin Wolf
2015-03-09 15:41 ` [Qemu-devel] [PULL 68/73] Add testcase for scsi-hd devices without drive property Kevin Wolf
2015-03-09 15:41 ` [Qemu-devel] [PULL 69/73] sheepdog: Fix misleading error messages in sd_snapshot_create() Kevin Wolf
2015-03-09 15:41 ` [Qemu-devel] [PULL 70/73] MAINTAINERS: Add jsnow as IDE maintainer Kevin Wolf
2015-03-09 15:41 ` [Qemu-devel] [PULL 71/73] block/raw-posix: fix launching with failed disks Kevin Wolf
2015-03-09 15:41 ` Kevin Wolf [this message]
2015-03-09 15:41 ` [Qemu-devel] [PULL 73/73] MAINTAINERS: Add jcody as blockjobs, block devices maintainer Kevin Wolf
2015-03-10 10:49 ` [Qemu-devel] [PULL 00/73] Block patches Peter Maydell
2015-03-10 11:00 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425915718-25138-13-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).