From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YV0xt-0000qp-7z for qemu-devel@nongnu.org; Mon, 09 Mar 2015 12:55:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YV0xk-0004jG-Jd for qemu-devel@nongnu.org; Mon, 09 Mar 2015 12:55:37 -0400 Message-ID: <1425920102.20588.48.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Mon, 09 Mar 2015 17:55:02 +0100 In-Reply-To: <54FDC9B8.2000706@redhat.com> References: <1425813387-31231-1-git-send-email-marcel@redhat.com> <1425887036.17517.17.camel@nilsson.home.kraxel.org> <54FD65F0.1040007@redhat.com> <1425896323.20588.15.camel@nilsson.home.kraxel.org> <54FD7442.5090508@redhat.com> <1425910792.20588.19.camel@nilsson.home.kraxel.org> <54FDC9B8.2000706@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 for-2.3 00/25] hw/pc: implement multiple primary busses for pc machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: seabios@seabios.org, mst@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, alex.williamson@redhat.com, kevin@koconnor.net, qemu-ppc@nongnu.org, hare@suse.de, imammedo@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, leon.alrae@imgtec.com, aurelien@aurel32.net, rth@twiddle.net On Mo, 2015-03-09 at 18:26 +0200, Marcel Apfelbaum wrote: > On 03/09/2015 04:19 PM, Gerd Hoffmann wrote: > > Hi, > > > >> My series is based on commit 09d219a. Try please on top of this commit. > > > > Ok, that works. Going to play with that now ;) > Good luck! ... and tell me what you think :) > If you need any help with the command line of the pxb device, let me know,. First thing I've noticed: You need to define a numa node so you can pass a valid numa node to the pxb-device. Guess that is ok as the whole point of this is to assign pci devices to numa nodes. More complete test instructions would be nice though. Second thing: Booting with an unpatched seabios has bad effects: [root@localhost ~]# cat /proc/iomem 00000000-000fffff : PCI Bus 0000:10 00000000-00000fff : reserved 00001000-0009fbff : System RAM 0009fc00-0009ffff : reserved 000c0000-000c91ff : Video ROM 000c9800-000ca1ff : Adapter ROM 000ca800-000ccbff : Adapter ROM 000f0000-000fffff : reserved 000f0000-000fffff : System ROM 00100000-3ffdffff : System RAM 01000000-0174bde4 : Kernel code 0174bde5-01d30cff : Kernel data 01eaa000-0202afff : Kernel bss 3ffe0000-3fffffff : reserved fd000000-fdffffff : 0000:00:02.0 fd000000-fdffffff : bochs-drm febc0000-febdffff : 0000:00:03.0 febc0000-febdffff : e1000 febf0000-febf0fff : 0000:00:02.0 febf0000-febf0fff : bochs-drm fec00000-fec003ff : IOAPIC 0 fed00000-fed003ff : HPET 0 fed00000-fed003ff : PNP0103:00 fee00000-fee00fff : Local APIC feffc000-feffffff : reserved fffc0000-ffffffff : reserved "PCI Bus 0000:10" is bogus and "PCI Bus 0000:00" isn't there at all. cheers, Gerd