From: "Denis V. Lunev" <den@openvz.org>
Cc: Kevin Wolf <kwolf@redhat.com>, "Denis V. Lunev" <den@openvz.org>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 13/27] block/parallels: rename catalog_ names to bat_
Date: Tue, 10 Mar 2015 11:51:07 +0300 [thread overview]
Message-ID: <1425977481-13317-14-git-send-email-den@openvz.org> (raw)
In-Reply-To: <1425977481-13317-1-git-send-email-den@openvz.org>
BAT means 'block allocation table'. Thus this name is clean and shorter
on writing.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Roman Kagan <rkagan@parallels.com>
CC: Kevin Wolf <kwolf@redhat.com>
CC: Stefan Hajnoczi <stefanha@redhat.com>
---
block/parallels.c | 54 +++++++++++++++++++++++++++---------------------------
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index 7ef3136..3d5f509 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -47,7 +47,7 @@ typedef struct ParallelsHeader {
uint32_t heads;
uint32_t cylinders;
uint32_t tracks;
- uint32_t catalog_entries;
+ uint32_t bat_entries;
uint64_t nb_sectors;
uint32_t inuse;
uint32_t data_off;
@@ -57,8 +57,8 @@ typedef struct ParallelsHeader {
typedef struct BDRVParallelsState {
CoMutex lock;
- uint32_t *catalog_bitmap;
- unsigned int catalog_size;
+ uint32_t *bat_bitmap;
+ unsigned int bat_size;
unsigned int tracks;
@@ -119,26 +119,26 @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags,
goto fail;
}
- s->catalog_size = le32_to_cpu(ph.catalog_entries);
- if (s->catalog_size > INT_MAX / sizeof(uint32_t)) {
+ s->bat_size = le32_to_cpu(ph.bat_entries);
+ if (s->bat_size > INT_MAX / sizeof(uint32_t)) {
error_setg(errp, "Catalog too large");
ret = -EFBIG;
goto fail;
}
- s->catalog_bitmap = g_try_new(uint32_t, s->catalog_size);
- if (s->catalog_size && s->catalog_bitmap == NULL) {
+ s->bat_bitmap = g_try_new(uint32_t, s->bat_size);
+ if (s->bat_size && s->bat_bitmap == NULL) {
ret = -ENOMEM;
goto fail;
}
ret = bdrv_pread(bs->file, sizeof(ParallelsHeader),
- s->catalog_bitmap, s->catalog_size * sizeof(uint32_t));
+ s->bat_bitmap, s->bat_size * sizeof(uint32_t));
if (ret < 0) {
goto fail;
}
- for (i = 0; i < s->catalog_size; i++)
- le32_to_cpus(&s->catalog_bitmap[i]);
+ for (i = 0; i < s->bat_size; i++)
+ le32_to_cpus(&s->bat_bitmap[i]);
qemu_co_mutex_init(&s->lock);
return 0;
@@ -147,7 +147,7 @@ fail_format:
error_setg(errp, "Image not in Parallels format");
ret = -EINVAL;
fail:
- g_free(s->catalog_bitmap);
+ g_free(s->bat_bitmap);
return ret;
}
@@ -159,9 +159,9 @@ static int64_t seek_to_sector(BDRVParallelsState *s, int64_t sector_num)
offset = sector_num % s->tracks;
/* not allocated */
- if ((index >= s->catalog_size) || (s->catalog_bitmap[index] == 0))
+ if ((index >= s->bat_size) || (s->bat_bitmap[index] == 0))
return -1;
- return (uint64_t)s->catalog_bitmap[index] * s->off_multiplier + offset;
+ return (uint64_t)s->bat_bitmap[index] * s->off_multiplier + offset;
}
static int cluster_remainder(BDRVParallelsState *s, int64_t sector_num,
@@ -181,25 +181,25 @@ static int64_t allocate_cluster(BlockDriverState *bs, int64_t sector_num)
idx = sector_num / s->tracks;
offset = sector_num % s->tracks;
- if (idx >= s->catalog_size) {
+ if (idx >= s->bat_size) {
return -EINVAL;
}
- if (s->catalog_bitmap[idx] != 0) {
- return (uint64_t)s->catalog_bitmap[idx] * s->off_multiplier + offset;
+ if (s->bat_bitmap[idx] != 0) {
+ return (uint64_t)s->bat_bitmap[idx] * s->off_multiplier + offset;
}
pos = bdrv_getlength(bs->file) >> BDRV_SECTOR_BITS;
bdrv_truncate(bs->file, (pos + s->tracks) << BDRV_SECTOR_BITS);
- s->catalog_bitmap[idx] = pos / s->off_multiplier;
+ s->bat_bitmap[idx] = pos / s->off_multiplier;
- tmp = cpu_to_le32(s->catalog_bitmap[idx]);
+ tmp = cpu_to_le32(s->bat_bitmap[idx]);
ret = bdrv_pwrite_sync(bs->file,
sizeof(ParallelsHeader) + idx * sizeof(tmp), &tmp, sizeof(tmp));
if (ret < 0) {
return ret;
}
- return (uint64_t)s->catalog_bitmap[idx] * s->off_multiplier + offset;
+ return (uint64_t)s->bat_bitmap[idx] * s->off_multiplier + offset;
}
static int64_t coroutine_fn parallels_co_get_block_status(BlockDriverState *bs,
@@ -313,7 +313,7 @@ static int parallels_create(const char *filename, QemuOpts *opts, Error **errp)
uint8_t tmp[BDRV_SECTOR_SIZE];
Error *local_err = NULL;
BlockDriverState *file;
- uint32_t cat_entries, cat_sectors;
+ uint32_t bat_entries, bat_sectors;
ParallelsHeader header;
int ret;
@@ -340,10 +340,10 @@ static int parallels_create(const char *filename, QemuOpts *opts, Error **errp)
goto exit;
}
- cat_entries = DIV_ROUND_UP(total_size, cl_size);
- cat_sectors = DIV_ROUND_UP(cat_entries * sizeof(uint32_t) +
+ bat_entries = DIV_ROUND_UP(total_size, cl_size);
+ bat_sectors = DIV_ROUND_UP(bat_entries * sizeof(uint32_t) +
sizeof(ParallelsHeader), cl_size);
- cat_sectors = (cat_sectors * cl_size) >> BDRV_SECTOR_BITS;
+ bat_sectors = (bat_sectors * cl_size) >> BDRV_SECTOR_BITS;
memset(&header, 0, sizeof(header));
memcpy(header.magic, HEADER_MAGIC2, sizeof(header.magic));
@@ -352,9 +352,9 @@ static int parallels_create(const char *filename, QemuOpts *opts, Error **errp)
header.heads = cpu_to_le32(16);
header.cylinders = cpu_to_le32(total_size / BDRV_SECTOR_SIZE / 16 / 32);
header.tracks = cpu_to_le32(cl_size >> BDRV_SECTOR_BITS);
- header.catalog_entries = cpu_to_le32(cat_entries);
+ header.bat_entries = cpu_to_le32(bat_entries);
header.nb_sectors = cpu_to_le64(DIV_ROUND_UP(total_size, BDRV_SECTOR_SIZE));
- header.data_off = cpu_to_le32(cat_sectors);
+ header.data_off = cpu_to_le32(bat_sectors);
/* write all the data */
memset(tmp, 0, sizeof(tmp));
@@ -364,7 +364,7 @@ static int parallels_create(const char *filename, QemuOpts *opts, Error **errp)
if (ret < 0) {
goto exit;
}
- ret = bdrv_write_zeroes(file, 1, cat_sectors - 1, 0);
+ ret = bdrv_write_zeroes(file, 1, bat_sectors - 1, 0);
if (ret < 0) {
goto exit;
}
@@ -382,7 +382,7 @@ exit:
static void parallels_close(BlockDriverState *bs)
{
BDRVParallelsState *s = bs->opaque;
- g_free(s->catalog_bitmap);
+ g_free(s->bat_bitmap);
}
static QemuOptsList parallels_create_opts = {
--
1.9.1
next prev parent reply other threads:[~2015-03-10 8:51 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 8:50 [Qemu-devel] [PATCH v3 0/27] write/create for Parallels images with reasonable performance Denis V. Lunev
2015-03-10 8:50 ` [Qemu-devel] [PATCH 01/27] iotests, parallels: quote TEST_IMG in 076 test to be path-safe Denis V. Lunev
2015-03-10 8:50 ` [Qemu-devel] [PATCH 02/27] block/parallels: rename parallels_header to ParallelsHeader Denis V. Lunev
2015-03-10 8:50 ` [Qemu-devel] [PATCH 03/27] block/parallels: switch to bdrv_read Denis V. Lunev
2015-03-10 8:50 ` [Qemu-devel] [PATCH 04/27] block/parallels: read up to cluster end in one go Denis V. Lunev
2015-03-10 8:50 ` [Qemu-devel] [PATCH 05/27] block/parallels: add get_block_status Denis V. Lunev
2015-03-10 8:51 ` [Qemu-devel] [PATCH 06/27] block/parallels: provide _co_readv routine for parallels format driver Denis V. Lunev
2015-03-10 8:51 ` [Qemu-devel] [PATCH 07/27] block/parallels: replace magic constants 4, 64 with proper sizeofs Denis V. Lunev
2015-03-10 8:51 ` [Qemu-devel] [PATCH 08/27] block/parallels: _co_writev callback for Parallels format Denis V. Lunev
2015-03-10 8:51 ` [Qemu-devel] [PATCH 09/27] iotests, parallels: test for write into Parallels image Denis V. Lunev
2015-03-10 8:51 ` [Qemu-devel] [PATCH 10/27] block/parallels: support parallels image creation Denis V. Lunev
2015-03-10 8:51 ` [Qemu-devel] [PATCH 11/27] iotests, parallels: test for newly created parallels image via qemu-img Denis V. Lunev
2015-03-10 8:51 ` [Qemu-devel] [PATCH 12/27] parallels: change copyright information in the image header Denis V. Lunev
2015-03-10 8:51 ` Denis V. Lunev [this message]
2015-03-10 8:51 ` [Qemu-devel] [PATCH 14/27] block/parallels: create bat2sect helper Denis V. Lunev
2015-03-10 12:14 ` Roman Kagan
2015-03-10 8:51 ` [Qemu-devel] [PATCH 15/27] block/parallels: keep BAT bitmap data in little endian in memory Denis V. Lunev
2015-03-10 12:16 ` Roman Kagan
2015-03-10 8:51 ` [Qemu-devel] [PATCH 16/27] block/parallels: read parallels image header and BAT into single buffer Denis V. Lunev
2015-03-10 14:07 ` Roman Kagan
2015-03-10 8:51 ` [Qemu-devel] [PATCH 17/27] block/parallels: move parallels_open/probe to the very end of the file Denis V. Lunev
2015-03-10 14:09 ` Roman Kagan
2015-03-10 8:51 ` [Qemu-devel] [PATCH 18/27] block/parallels: implement parallels_check method of block driver Denis V. Lunev
2015-03-10 14:24 ` Roman Kagan
2015-03-10 14:29 ` Denis V. Lunev
2015-03-10 8:51 ` [Qemu-devel] [PATCH 19/27] block/parallels: implement incorrect close detection Denis V. Lunev
2015-03-10 14:38 ` Roman Kagan
2015-03-10 14:44 ` Denis V. Lunev
2015-03-10 14:51 ` Roman Kagan
2015-03-10 8:51 ` [Qemu-devel] [PATCH 20/27] iotests, parallels: check for incorrectly closed image in tests Denis V. Lunev
2015-03-10 14:39 ` Roman Kagan
2015-03-10 8:51 ` [Qemu-devel] [PATCH 21/27] block/parallels: no need to flush on each block allocation table update Denis V. Lunev
2015-03-10 14:41 ` Roman Kagan
2015-03-10 8:51 ` [Qemu-devel] [PATCH 22/27] block/parallels: improve image reading performance Denis V. Lunev
2015-03-10 14:50 ` Roman Kagan
2015-03-10 8:51 ` [Qemu-devel] [PATCH 23/27] block/parallels: create bat_entry_off helper Denis V. Lunev
2015-03-10 14:52 ` Roman Kagan
2015-03-10 8:51 ` [Qemu-devel] [PATCH 24/27] block/parallels: delay writing to BAT till bdrv_co_flush_to_os Denis V. Lunev
2015-03-10 15:04 ` Roman Kagan
2015-03-10 8:51 ` [Qemu-devel] [PATCH 25/27] block/parallels: add prealloc-mode and prealloc-size open paramemets Denis V. Lunev
2015-03-10 15:05 ` Roman Kagan
2015-03-10 8:51 ` [Qemu-devel] [PATCH 26/27] block/parallels: optimize linear image expansion Denis V. Lunev
2015-03-10 15:10 ` Roman Karan
2015-03-10 8:51 ` [Qemu-devel] [PATCH 27/27] block/parallels: improve image writing performance further Denis V. Lunev
2015-03-11 9:25 ` Roman Kagan
-- strict thread matches above, loose matches on Subject: below --
2015-03-11 10:27 [Qemu-devel] [PATCH v3 0/27] write/create for Parallels images with reasonable performance Denis V. Lunev
2015-03-11 10:28 ` [Qemu-devel] [PATCH 13/27] block/parallels: rename catalog_ names to bat_ Denis V. Lunev
2015-04-22 13:28 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425977481-13317-14-git-send-email-den@openvz.org \
--to=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).