From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVdrk-0008Pg-Aa for qemu-devel@nongnu.org; Wed, 11 Mar 2015 06:27:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVdrf-0003xj-7b for qemu-devel@nongnu.org; Wed, 11 Mar 2015 06:27:52 -0400 Received: from mailhub.sw.ru ([195.214.232.25]:48925 helo=relay.sw.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVdre-0003u8-KK for qemu-devel@nongnu.org; Wed, 11 Mar 2015 06:27:46 -0400 From: "Denis V. Lunev" Date: Wed, 11 Mar 2015 13:28:09 +0300 Message-Id: <1426069701-1405-16-git-send-email-den@openvz.org> In-Reply-To: <1426069701-1405-1-git-send-email-den@openvz.org> References: <1426069701-1405-1-git-send-email-den@openvz.org> Subject: [Qemu-devel] [PATCH 15/27] block/parallels: keep BAT bitmap data in little endian in memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "Denis V. Lunev" , qemu-devel@nongnu.org, Stefan Hajnoczi This will allow to use this data as buffer to BAT update directly without any intermediate buffers. Signed-off-by: Denis V. Lunev Reviewed-by: Roman Kagan CC: Kevin Wolf CC: Stefan Hajnoczi --- block/parallels.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index 6bc5e62..8301de4 100644 --- a/block/parallels.c +++ b/block/parallels.c @@ -84,7 +84,6 @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags, Error **errp) { BDRVParallelsState *s = bs->opaque; - int i; ParallelsHeader ph; int ret; @@ -137,10 +136,6 @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags, goto fail; } - for (i = 0; i < s->bat_size; i++) { - le32_to_cpus(&s->bat_bitmap[i]); - } - qemu_co_mutex_init(&s->lock); return 0; @@ -155,7 +150,7 @@ fail: static int64_t bat2sect(BDRVParallelsState *s, uint32_t idx) { - return (uint64_t)s->bat_bitmap[idx] * s->off_multiplier; + return (uint64_t)le32_to_cpu(s->bat_bitmap[idx]) * s->off_multiplier; } static int64_t seek_to_sector(BDRVParallelsState *s, int64_t sector_num) @@ -182,7 +177,7 @@ static int cluster_remainder(BDRVParallelsState *s, int64_t sector_num, static int64_t allocate_cluster(BlockDriverState *bs, int64_t sector_num) { BDRVParallelsState *s = bs->opaque; - uint32_t idx, offset, tmp; + uint32_t idx, offset; int64_t pos; int ret; @@ -198,12 +193,11 @@ static int64_t allocate_cluster(BlockDriverState *bs, int64_t sector_num) pos = bdrv_getlength(bs->file) >> BDRV_SECTOR_BITS; bdrv_truncate(bs->file, (pos + s->tracks) << BDRV_SECTOR_BITS); - s->bat_bitmap[idx] = pos / s->off_multiplier; - - tmp = cpu_to_le32(s->bat_bitmap[idx]); + s->bat_bitmap[idx] = cpu_to_le32(pos / s->off_multiplier); ret = bdrv_pwrite_sync(bs->file, - sizeof(ParallelsHeader) + idx * sizeof(tmp), &tmp, sizeof(tmp)); + sizeof(ParallelsHeader) + idx * sizeof(s->bat_bitmap[idx]), + s->bat_bitmap + idx, sizeof(s->bat_bitmap[idx])); if (ret < 0) { return ret; } -- 1.9.1