From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47526)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YVejz-0001bg-IZ
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 07:23:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YVejw-0006PN-DA
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 07:23:55 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:60251)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YVejw-0006PD-9D
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 07:23:52 -0400
Message-ID: <1426073029.21353.185.camel@citrix.com>
From: Ian Campbell <ian.campbell@citrix.com>
Date: Wed, 11 Mar 2015 11:23:49 +0000
In-Reply-To: <54FD4190.80606@intel.com>
References: <1425632903-5502-1-git-send-email-tiejun.chen@intel.com>
	<1425632903-5502-3-git-send-email-tiejun.chen@intel.com>
	<20150306125545.GP12103@zion.uk.xensource.com>
	<54FD4190.80606@intel.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: Ian.Jackson@eu.citrix.com, Wei Liu <wei.liu2@citrix.com>, qemu-devel@nongnu.org, stefano.stabellini@citrix.com, xen-devel@lists.xen.org

On Mon, 2015-03-09 at 14:45 +0800, Chen, Tiejun wrote:
> On 2015/3/6 20:55, Wei Liu wrote:
> > On Fri, Mar 06, 2015 at 05:08:23PM +0800, Tiejun Chen wrote:
> >> Although we already have 'gfx_passthru' in b_info, this doesn' suffice
                                                                   ^t

> >> after we want to handle IGD specifically. Now we define a new field of
> >> type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually
> >> this means we can benefit this to support other specific devices just
> >> by extending gfx_passthru_kind. And then we can cooperate with
> >> gfx_passthru to address IGD cases as follows:
> >>
> >>      gfx_passthru = 0    => sets build_info.u.gfx_passthru to false
> >>      gfx_passthru = 1    => sets build_info.u.gfx_passthru to false and
> >                                                                 ^^^^^
> >                                                                 true?
> 
> I just simply pick up this from Campbell's comment but I agree you.

Sorry! Wei is right.