From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50313)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YVgWx-0001yF-AN
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 09:18:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YVgWu-0005RO-4K
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 09:18:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46510)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YVgWt-0005RH-Jc
	for qemu-devel@nongnu.org; Wed, 11 Mar 2015 09:18:31 -0400
Message-ID: <1426079906.28125.5.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 11 Mar 2015 14:18:26 +0100
In-Reply-To: <54FF12BE.7070605@redhat.com>
References: <1425986326-28797-1-git-send-email-kraxel@redhat.com>
	<1425986326-28797-4-git-send-email-kraxel@redhat.com>
	<54FF12BE.7070605@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] vnc: switch to inet_listen_opts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>

On Di, 2015-03-10 at 16:50 +0100, Paolo Bonzini wrote:
> 
> On 10/03/2015 12:18, Gerd Hoffmann wrote:
> > Use inet_listen_opts instead of inet_listen.  Allows us to drop some
> > pointless indirection:  Format strings just to parse them again later on.
> 
> Maybe use socket_listen then?

Hmm, mapping "vnc qemuopts" -> "socket qemuopts" looks a bit easier than
mapping "vnc qemuopts" -> SocketAddress, which will then be translated
into "socket qemuopts" anyway ...

cheers,
  Gerd