From: Gerd Hoffmann <kraxel@redhat.com>
To: Gonglei <arei.gonglei@huawei.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] vnc: switch to inet_listen_opts
Date: Wed, 11 Mar 2015 14:20:21 +0100 [thread overview]
Message-ID: <1426080021.28125.7.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <54FFA3AA.909@huawei.com>
Hi,
> > + qemu_opt_set(sopts, "port", h+1);
>
> Maybe you missed passing '&error_abort' or something like that:
>
> ui/vnc.c:3371: error: too few arguments to function ‘qemu_opt_set’
> ui/vnc.c:3372: error: too few arguments to function ‘qemu_opt_set’
> ui/vnc.c:3373: error: too few arguments to function ‘qemu_opt_set’
> ui/vnc.c:3384: error: too few arguments to function ‘qemu_opt_set’
>
> as the same as below several places of calling qemu_opt_set().
Looks like a a error handling series from markus was merged meanwhile,
need to rebase & adapt patch.
cheers,
Gerd
prev parent reply other threads:[~2015-03-11 13:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 11:18 [Qemu-devel] [PATCH 0/3] vnc: some code cleanups Gerd Hoffmann
2015-03-10 11:18 ` [Qemu-devel] [PATCH 1/3] vnc: drop display+ws_display from VncDisplay Gerd Hoffmann
2015-03-11 1:58 ` Gonglei
2015-03-10 11:18 ` [Qemu-devel] [PATCH 2/3] vnc: remove dead code Gerd Hoffmann
2015-03-11 1:59 ` Gonglei
2015-03-10 11:18 ` [Qemu-devel] [PATCH 3/3] vnc: switch to inet_listen_opts Gerd Hoffmann
2015-03-10 15:50 ` Paolo Bonzini
2015-03-11 13:18 ` Gerd Hoffmann
2015-03-11 2:08 ` Gonglei
2015-03-11 13:20 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426080021.28125.7.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=aliguori@amazon.com \
--cc=arei.gonglei@huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).