From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVh63-000204-Q7 for qemu-devel@nongnu.org; Wed, 11 Mar 2015 09:54:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVh60-0001gQ-FI for qemu-devel@nongnu.org; Wed, 11 Mar 2015 09:54:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVh60-0001g9-5t for qemu-devel@nongnu.org; Wed, 11 Mar 2015 09:54:48 -0400 Message-ID: <1426080021.28125.7.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Wed, 11 Mar 2015 14:20:21 +0100 In-Reply-To: <54FFA3AA.909@huawei.com> References: <1425986326-28797-1-git-send-email-kraxel@redhat.com> <1425986326-28797-4-git-send-email-kraxel@redhat.com> <54FFA3AA.909@huawei.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/3] vnc: switch to inet_listen_opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gonglei Cc: qemu-devel@nongnu.org, Anthony Liguori Hi, > > + qemu_opt_set(sopts, "port", h+1); >=20 > Maybe you missed passing '&error_abort' or something like that: >=20 > ui/vnc.c:3371: error: too few arguments to function =E2=80=98qemu_opt_s= et=E2=80=99 > ui/vnc.c:3372: error: too few arguments to function =E2=80=98qemu_opt_s= et=E2=80=99 > ui/vnc.c:3373: error: too few arguments to function =E2=80=98qemu_opt_s= et=E2=80=99 > ui/vnc.c:3384: error: too few arguments to function =E2=80=98qemu_opt_s= et=E2=80=99 >=20 > as the same as below several places of calling qemu_opt_set(). Looks like a a error handling series from markus was merged meanwhile, need to rebase & adapt patch. cheers, Gerd