From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVkGF-0003kH-6j for qemu-devel@nongnu.org; Wed, 11 Mar 2015 13:17:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVkGB-00048E-W7 for qemu-devel@nongnu.org; Wed, 11 Mar 2015 13:17:35 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:38086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVkGB-000487-Q4 for qemu-devel@nongnu.org; Wed, 11 Mar 2015 13:17:31 -0400 Received: by wghl18 with SMTP id l18so10784038wgh.5 for ; Wed, 11 Mar 2015 10:17:30 -0700 (PDT) From: Eric Auger Date: Wed, 11 Mar 2015 17:17:06 +0000 Message-Id: <1426094226-8515-1-git-send-email-eric.auger@linaro.org> Subject: [Qemu-devel] [PATCH v5] hw/intc/arm_gic: Initialize the vgic in the realize function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: eric.auger@st.com, eric.auger@linaro.org, qemu-devel@nongnu.org, peter.maydell@linaro.org Cc: kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org, patches@linaro.org This patch forces vgic initialization in the vgic realize function. It uses a new group/attribute that allows such operation: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_INIT This earlier initialization allows, for example, to setup VFIO signaling and irqfd after vgic initialization, on a reset notifier. Signed-off-by: Eric Auger --- v4 -> v5: - add a comment to clarify what the new gic accesses aim at - header sync removed. The series becomes a singleton. v1 -> v2: - The init is not mandated to be done in a machine init done notifier anymore since only the number of vcpus and number of IRQs must be known at init time. --- hw/intc/arm_gic_kvm.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/intc/arm_gic_kvm.c b/hw/intc/arm_gic_kvm.c index 1ad3eb0..0d20750 100644 --- a/hw/intc/arm_gic_kvm.c +++ b/hw/intc/arm_gic_kvm.c @@ -573,6 +573,13 @@ static void kvm_arm_gic_realize(DeviceState *dev, Error **errp) kvm_gic_access(s, KVM_DEV_ARM_VGIC_GRP_NR_IRQS, 0, 0, &numirqs, 1); } + /* Tell the kernel to complete VGIC initialization now */ + if (kvm_gic_supports_attr(s, KVM_DEV_ARM_VGIC_GRP_CTRL, + KVM_DEV_ARM_VGIC_CTRL_INIT)) { + kvm_gic_access(s, KVM_DEV_ARM_VGIC_GRP_CTRL, + KVM_DEV_ARM_VGIC_CTRL_INIT, 0, 0, 1); + } + /* Distributor */ memory_region_init_reservation(&s->iomem, OBJECT(s), "kvm-gic_dist", 0x1000); -- 1.8.3.2