From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVyyt-0000Fd-Ty for qemu-devel@nongnu.org; Thu, 12 Mar 2015 05:00:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVyyt-00057U-46 for qemu-devel@nongnu.org; Thu, 12 Mar 2015 05:00:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVyys-00057L-Sw for qemu-devel@nongnu.org; Thu, 12 Mar 2015 05:00:39 -0400 From: Gerd Hoffmann Date: Thu, 12 Mar 2015 10:00:24 +0100 Message-Id: <1426150825-782-7-git-send-email-kraxel@redhat.com> In-Reply-To: <1426150825-782-1-git-send-email-kraxel@redhat.com> References: <1426150825-782-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 6/7] vnc: avoid possible file handler leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gonglei , Gerd Hoffmann , Anthony Liguori From: Gonglei vs->lsock may equal to 0, modify the check condition, avoid possible vs->lsock leak. Signed-off-by: Gonglei Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index b514777..1e95445 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3644,7 +3644,7 @@ void vnc_display_open(const char *id, Error **errp) if (vs->ws_enabled) { vs->lwebsock = inet_listen_opts(wsopts, 0, errp); if (vs->lwebsock < 0) { - if (vs->lsock) { + if (vs->lsock != -1) { close(vs->lsock); vs->lsock = -1; } -- 1.8.3.1