qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL v2 0/5] sdl patch queue.
Date: Thu, 12 Mar 2015 11:48:22 +0100	[thread overview]
Message-ID: <1426157302.1722.17.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <CAFEAcA-O+1xBh_HVCBPQSrVPv+KW0D1-AEfE78x7dhSss_ZmDw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 388 bytes --]

  Hi,

> Still fails to build on OSX:
> 
> manooth$ make -C build/all
>   CC    lm32-softmmu/hw/lm32/milkymist.o
> In file included from /Users/pm215/src/qemu/hw/lm32/milkymist.c:30:
> /Users/pm215/src/qemu/hw/lm32/milkymist-hw.h:90:10: fatal error:
> 'X11/Xlib.h' file not found
> #include <X11/Xlib.h>
>          ^
> 1 error generated.

Does the attached patch fix it?

cheers,
  Gerd


[-- Attachment #2: 0001-opengl-require-glx.patch --]
[-- Type: text/x-patch, Size: 1104 bytes --]

>From fffbae0bcc7480d3b3dd145c93cb3c36860ebcf6 Mon Sep 17 00:00:00 2001
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 12 Mar 2015 11:44:11 +0100
Subject: [PATCH] opengl: require glx

hw/display/milkymist-tmu2.c uses glx.  That will be replaced with egl in
the future, with qemu getting more opengl support.  But we are not there
yet, so put it back into configure to fix build failures on machines
without glx (i.e. macos, possibly windows too).

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index bd55786..ed49990 100755
--- a/configure
+++ b/configure
@@ -3120,7 +3120,7 @@ libs_softmmu="$libs_softmmu $fdt_libs"
 ##########################################
 # opengl probe (for sdl2, milkymist-tmu2)
 if test "$opengl" != "no" ; then
-  opengl_pkgs="egl gl glesv2"
+  opengl_pkgs="glx egl gl glesv2"
   if $pkg_config $opengl_pkgs x11; then
     opengl_cflags="$($pkg_config --cflags $opengl_pkgs) $x11_cflags"
     opengl_libs="$($pkg_config --libs $opengl_pkgs) $x11_libs"
-- 
1.8.3.1


  reply	other threads:[~2015-03-12 10:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12  8:38 [Qemu-devel] [PULL v2 0/5] sdl patch queue Gerd Hoffmann
2015-03-12  8:38 ` [Qemu-devel] [PULL v2 1/5] sdl: Refresh debug statements Gerd Hoffmann
2015-03-12  8:38 ` [Qemu-devel] [PULL v2 2/5] sdl: Fix crash when calling sdl_switch() with NULL surface Gerd Hoffmann
2015-03-12  8:38 ` [Qemu-devel] [PULL v2 3/5] configure: opengl overhaul Gerd Hoffmann
2015-03-12  8:38 ` [Qemu-devel] [PULL v2 4/5] Allow the use of X11 from a non standard location Gerd Hoffmann
2015-03-12  8:38 ` [Qemu-devel] [PULL v2 5/5] pixman: add a bunch of PIXMAN_BE_* defines for 32bpp Gerd Hoffmann
2015-03-12 10:35 ` [Qemu-devel] [PULL v2 0/5] sdl patch queue Peter Maydell
2015-03-12 10:48   ` Gerd Hoffmann [this message]
2015-03-12 11:16     ` Peter Maydell
2015-03-12 14:54       ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426157302.1722.17.camel@nilsson.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).