qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Scott Feldman <sfeldma@gmail.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL v3 05/13] net: add MAC address string printer
Date: Thu, 12 Mar 2015 12:19:49 +0000	[thread overview]
Message-ID: <1426162797-27548-6-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1426162797-27548-1-git-send-email-stefanha@redhat.com>

From: Scott Feldman <sfeldma@gmail.com>

We can use this in virtio-net code as well as new Rocker driver code, so
up-level this.

Signed-off-by: Scott Feldman <sfeldma@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 1424123271-7656-2-git-send-email-sfeldma@gmail.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 include/net/net.h | 1 +
 net/net.c         | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/include/net/net.h b/include/net/net.h
index 50ffcb9..e66ca03 100644
--- a/include/net/net.h
+++ b/include/net/net.h
@@ -97,6 +97,7 @@ typedef struct NICState {
     bool peer_deleted;
 } NICState;
 
+char *qemu_mac_strdup_printf(const uint8_t *macaddr);
 NetClientState *qemu_find_netdev(const char *id);
 int qemu_find_net_clients_except(const char *id, NetClientState **ncs,
                                  NetClientOptionsKind type, int max);
diff --git a/net/net.c b/net/net.c
index 0be084d..7427f6a 100644
--- a/net/net.c
+++ b/net/net.c
@@ -151,6 +151,13 @@ int parse_host_port(struct sockaddr_in *saddr, const char *str)
     return 0;
 }
 
+char *qemu_mac_strdup_printf(const uint8_t *macaddr)
+{
+    return g_strdup_printf("%.2x:%.2x:%.2x:%.2x:%.2x:%.2x",
+                           macaddr[0], macaddr[1], macaddr[2],
+                           macaddr[3], macaddr[4], macaddr[5]);
+}
+
 void qemu_format_nic_info_str(NetClientState *nc, uint8_t macaddr[6])
 {
     snprintf(nc->info_str, sizeof(nc->info_str),
-- 
2.1.0

  parent reply	other threads:[~2015-03-12 12:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 12:19 [Qemu-devel] [PULL v3 00/13] Net patches Stefan Hajnoczi
2015-03-12 12:19 ` [Qemu-devel] [PULL v3 01/13] configure: handle clang -nopie argument warning Stefan Hajnoczi
2015-03-12 12:19 ` [Qemu-devel] [PULL v3 02/13] configure: silence glib unknown attribute __alloc_size__ Stefan Hajnoczi
2015-03-12 12:19 ` [Qemu-devel] [PULL v3 03/13] net: synchronize net_host_device_remove with host_net_remove_completion Stefan Hajnoczi
2015-03-12 12:19 ` [Qemu-devel] [PULL v3 04/13] tests: rtl8139: test timers and interrupt Stefan Hajnoczi
2015-03-12 12:19 ` Stefan Hajnoczi [this message]
2015-03-12 12:19 ` [Qemu-devel] [PULL v3 06/13] virtio-net: use qemu_mac_strdup_printf Stefan Hajnoczi
2015-03-12 12:19 ` [Qemu-devel] [PULL v3 07/13] rocker: add register programming guide Stefan Hajnoczi
2015-03-12 12:19 ` [Qemu-devel] [PULL v3 08/13] pci: add rocker device ID Stefan Hajnoczi
2015-03-12 12:19 ` [Qemu-devel] [PULL v3 09/13] pci: add network device class 'other' for network switches Stefan Hajnoczi
2015-03-12 12:19 ` [Qemu-devel] [PULL v3 10/13] rocker: add new rocker switch device Stefan Hajnoczi
2015-03-12 12:19 ` [Qemu-devel] [PULL v3 11/13] rocker: add tests Stefan Hajnoczi
2015-03-12 12:19 ` [Qemu-devel] [PULL v3 12/13] MAINTAINERS: add rocker Stefan Hajnoczi
2015-03-12 12:19 ` [Qemu-devel] [PULL v3 13/13] rocker: timestamp on the debug logs helps correlate with events in the VM Stefan Hajnoczi
2015-03-12 12:37 ` [Qemu-devel] [PULL v3 00/13] Net patches Peter Maydell
2015-03-12 12:48   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426162797-27548-6-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sfeldma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).