* [Qemu-devel] [PATCH] s390x/config: Do not include full pci.mak
@ 2015-03-12 14:19 Thomas Huth
2015-03-13 10:13 ` Cornelia Huck
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2015-03-12 14:19 UTC (permalink / raw)
To: qemu-devel; +Cc: cornelia.huck, borntraeger, blaschka, agraf, Thomas Huth
pci.mak includes a lot of devices - and most of them do not make
sense on s390x, like USB controllers or audio cards. These devices
also show up when running "qemu-system-s390x -device help" and thus
could raise the hope for the users that they could use these kind
of devices with qemu-system-s390x. To avoid this confusion, we
should not include pci.mak and rather include the bare minimum
manually instead.
Signed-off-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Acked-by: Frank Blaschka <blaschka@linux.vnet.ibm.com>
---
default-configs/s390x-softmmu.mak | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/default-configs/s390x-softmmu.mak b/default-configs/s390x-softmmu.mak
index 6ee2ff8..f9e13f1 100644
--- a/default-configs/s390x-softmmu.mak
+++ b/default-configs/s390x-softmmu.mak
@@ -1,4 +1,5 @@
-include pci.mak
+CONFIG_PCI=y
+CONFIG_VIRTIO_PCI=y
CONFIG_VIRTIO=y
CONFIG_SCLPCONSOLE=y
CONFIG_S390_FLIC=y
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] s390x/config: Do not include full pci.mak
2015-03-12 14:19 [Qemu-devel] [PATCH] s390x/config: Do not include full pci.mak Thomas Huth
@ 2015-03-13 10:13 ` Cornelia Huck
0 siblings, 0 replies; 2+ messages in thread
From: Cornelia Huck @ 2015-03-13 10:13 UTC (permalink / raw)
To: Thomas Huth; +Cc: borntraeger, blaschka, qemu-devel, agraf
On Thu, 12 Mar 2015 15:19:14 +0100
Thomas Huth <thuth@linux.vnet.ibm.com> wrote:
> pci.mak includes a lot of devices - and most of them do not make
> sense on s390x, like USB controllers or audio cards. These devices
> also show up when running "qemu-system-s390x -device help" and thus
> could raise the hope for the users that they could use these kind
> of devices with qemu-system-s390x. To avoid this confusion, we
> should not include pci.mak and rather include the bare minimum
> manually instead.
>
> Signed-off-by: Thomas Huth <thuth@linux.vnet.ibm.com>
> Acked-by: Frank Blaschka <blaschka@linux.vnet.ibm.com>
> ---
> default-configs/s390x-softmmu.mak | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
Applied to my s390-next branch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-13 10:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-12 14:19 [Qemu-devel] [PATCH] s390x/config: Do not include full pci.mak Thomas Huth
2015-03-13 10:13 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).