From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47703)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YW4Vz-0001pW-HD
	for qemu-devel@nongnu.org; Thu, 12 Mar 2015 10:55:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YW4Vt-0002fb-DD
	for qemu-devel@nongnu.org; Thu, 12 Mar 2015 10:55:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56337)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YW4Vt-0002bu-6v
	for qemu-devel@nongnu.org; Thu, 12 Mar 2015 10:55:05 -0400
Message-ID: <1426172098.1722.20.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 12 Mar 2015 15:54:58 +0100
In-Reply-To: <CAFEAcA-vS=42sq0w-Bfc4uEtvn+FTsnP=9aoYAcmj8kiDgJ62g@mail.gmail.com>
References: <1426149496-6043-1-git-send-email-kraxel@redhat.com>
	<CAFEAcA-O+1xBh_HVCBPQSrVPv+KW0D1-AEfE78x7dhSss_ZmDw@mail.gmail.com>
	<1426157302.1722.17.camel@nilsson.home.kraxel.org>
	<CAFEAcA-vS=42sq0w-Bfc4uEtvn+FTsnP=9aoYAcmj8kiDgJ62g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL v2 0/5] sdl patch queue.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On Do, 2015-03-12 at 11:16 +0000, Peter Maydell wrote:
> On 12 March 2015 at 10:48, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >   Hi,
> >
> >> Still fails to build on OSX:
> >>
> >> manooth$ make -C build/all
> >>   CC    lm32-softmmu/hw/lm32/milkymist.o
> >> In file included from /Users/pm215/src/qemu/hw/lm32/milkymist.c:30:
> >> /Users/pm215/src/qemu/hw/lm32/milkymist-hw.h:90:10: fatal error:
> >> 'X11/Xlib.h' file not found
> >> #include <X11/Xlib.h>
> >>          ^
> >> 1 error generated.
> >
> > Does the attached patch fix it?
> 
> That patch doesn't apply, because it does:
> 
> -  opengl_pkgs="egl gl glesv2"
> +  opengl_pkgs="glx egl gl glesv2"
> 
> but the configure as of your pull req has just:
>   opengl_pkgs="gl"

Oh, right, there is some wip opengl stuff in the sdl branch.

Fixed it in patch #3, created a new tag: pull-sdl-20150312-2

Does that build for you?

cheers,
  Gerd