From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW5wn-0004bM-Tx for qemu-devel@nongnu.org; Thu, 12 Mar 2015 12:26:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YW5wn-0001mr-3M for qemu-devel@nongnu.org; Thu, 12 Mar 2015 12:26:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW5wm-0001mR-SR for qemu-devel@nongnu.org; Thu, 12 Mar 2015 12:26:57 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2CGQtut021297 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 12 Mar 2015 12:26:56 -0400 From: Markus Armbruster Date: Thu, 12 Mar 2015 17:26:50 +0100 Message-Id: <1426177610-4848-6-git-send-email-armbru@redhat.com> In-Reply-To: <1426177610-4848-1-git-send-email-armbru@redhat.com> References: <1426177610-4848-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 5/5] usb/dev-storage: Avoid qerror_report_err() outside QMP handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kraxel@redhat.com, lcapitulino@redhat.com qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. usb_msd_password_cb() is only called from within an HMP command handler. Replace by error_report_err(). Signed-off-by: Markus Armbruster --- hw/usb/dev-storage.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index f50bcb8..ae8d40d 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -559,8 +559,7 @@ static void usb_msd_password_cb(void *opaque, int err) } if (local_err) { - qerror_report_err(local_err); - error_free(local_err); + error_report_err(local_err); qdev_unplug(&s->dev.qdev, NULL); } } -- 1.9.3