From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH v2 3/4] exec: Notify cpu_register_map_client caller if the bounce buffer is available
Date: Fri, 13 Mar 2015 09:38:42 +0800 [thread overview]
Message-ID: <1426210723-16735-4-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1426210723-16735-1-git-send-email-famz@redhat.com>
The caller's workflow is like
if (!address_space_map()) {
...
cpu_register_map_client();
}
If bounce buffer became available after address_space_map() but before
cpu_register_map_client(), the caller could miss it and has to wait for the
next bounce buffer uesr to release, which may never happen in the worse case.
Just notify the caller with the passed callback in cpu_register_map_client().
Signed-off-by: Fam Zheng <famz@redhat.com>
---
exec.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/exec.c b/exec.c
index 93ccd5a..82781e4 100644
--- a/exec.c
+++ b/exec.c
@@ -2502,6 +2502,9 @@ void *cpu_register_map_client(void *opaque, void (*callback)(void *opaque))
client->opaque = opaque;
client->callback = callback;
QSLIST_INSERT_HEAD_ATOMIC(&map_client_list, client, link);
+ if (!atomic_read(&bounce.in_use)) {
+ callback(opaque);
+ }
return client;
}
--
1.9.3
next prev parent reply other threads:[~2015-03-13 1:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 1:38 [Qemu-devel] [PATCH v2 0/4] exec: Make bounce buffer thread safe Fam Zheng
2015-03-13 1:38 ` [Qemu-devel] [PATCH v2 1/4] exec: Atomic access to bounce buffer Fam Zheng
2015-03-13 8:09 ` Paolo Bonzini
2015-03-13 8:16 ` Fam Zheng
2015-03-13 8:32 ` Paolo Bonzini
2015-03-13 8:38 ` Fam Zheng
2015-03-13 8:41 ` Paolo Bonzini
2015-03-13 1:38 ` [Qemu-devel] [PATCH v2 2/4] exec: Atomic access to map_client_list Fam Zheng
2015-03-13 8:11 ` Paolo Bonzini
2015-03-13 1:38 ` Fam Zheng [this message]
2015-03-13 8:12 ` [Qemu-devel] [PATCH v2 3/4] exec: Notify cpu_register_map_client caller if the bounce buffer is available Paolo Bonzini
2015-03-13 1:38 ` [Qemu-devel] [PATCH v2 4/4] dma-helpers: Move reschedule_dma BH to blk's AioContext Fam Zheng
2015-03-13 8:13 ` Paolo Bonzini
2015-03-13 8:58 ` Fam Zheng
2015-03-13 10:48 ` Paolo Bonzini
2015-03-13 12:33 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426210723-16735-4-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).