From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWTcD-0004PG-9t for qemu-devel@nongnu.org; Fri, 13 Mar 2015 13:43:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YWTcA-0004E2-1Y for qemu-devel@nongnu.org; Fri, 13 Mar 2015 13:43:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWTc9-0004Do-Pp for qemu-devel@nongnu.org; Fri, 13 Mar 2015 13:43:13 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2DHhCIY008366 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 13 Mar 2015 13:43:12 -0400 From: Markus Armbruster Date: Fri, 13 Mar 2015 18:43:09 +0100 Message-Id: <1426268589-14756-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kraxel@redhat.com Error classes are a leftover from the days of "rich" error objects. New code should always use ERROR_CLASS_GENERIC_ERROR. Commit 1d0d59f added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. --- ui/vnc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index 6f9b718..a950016 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3594,7 +3594,7 @@ void vnc_display_open(const char *id, Error **errp) dev = qdev_find_recursive(sysbus_get_default(), device_id); if (dev == NULL) { - error_set(errp, QERR_DEVICE_NOT_FOUND, device_id); + error_setg(errp, "Device '%s' not found", device_id); goto fail; } -- 1.9.3