* [Qemu-devel] [PATCH] tcg/optimize: Handle or r, a, a with constant a
@ 2015-03-13 19:26 Richard Henderson
2015-03-14 0:54 ` Bastian Koppelmann
2015-03-15 12:42 ` Mark Cave-Ayland
0 siblings, 2 replies; 3+ messages in thread
From: Richard Henderson @ 2015-03-13 19:26 UTC (permalink / raw)
To: qemu-devel
As seen with ubuntu-5.10-live-powerpc.iso.
Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
tcg/optimize.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tcg/optimize.c b/tcg/optimize.c
index 067917c..37c1110 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -980,8 +980,11 @@ static void tcg_constant_folding(TCGContext *s)
if (temps_are_copies(args[1], args[2])) {
if (temps_are_copies(args[0], args[1])) {
tcg_op_remove(s, op);
- } else {
+ } else if (temps[args[1]].state != TCG_TEMP_CONST) {
tcg_opt_gen_mov(s, op, args, opc, args[0], args[1]);
+ } else {
+ tcg_opt_gen_movi(s, op, args, opc,
+ args[0], temps[args[1]].val);
}
continue;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] tcg/optimize: Handle or r, a, a with constant a
2015-03-13 19:26 [Qemu-devel] [PATCH] tcg/optimize: Handle or r, a, a with constant a Richard Henderson
@ 2015-03-14 0:54 ` Bastian Koppelmann
2015-03-15 12:42 ` Mark Cave-Ayland
1 sibling, 0 replies; 3+ messages in thread
From: Bastian Koppelmann @ 2015-03-14 0:54 UTC (permalink / raw)
To: Richard Henderson, qemu-devel
On 03/13/2015 07:26 PM, Richard Henderson wrote:
> As seen with ubuntu-5.10-live-powerpc.iso.
>
> Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
> tcg/optimize.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index 067917c..37c1110 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -980,8 +980,11 @@ static void tcg_constant_folding(TCGContext *s)
> if (temps_are_copies(args[1], args[2])) {
> if (temps_are_copies(args[0], args[1])) {
> tcg_op_remove(s, op);
> - } else {
> + } else if (temps[args[1]].state != TCG_TEMP_CONST) {
> tcg_opt_gen_mov(s, op, args, opc, args[0], args[1]);
> + } else {
> + tcg_opt_gen_movi(s, op, args, opc,
> + args[0], temps[args[1]].val);
> }
> continue;
> }
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Cheers,
Bastian
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] tcg/optimize: Handle or r, a, a with constant a
2015-03-13 19:26 [Qemu-devel] [PATCH] tcg/optimize: Handle or r, a, a with constant a Richard Henderson
2015-03-14 0:54 ` Bastian Koppelmann
@ 2015-03-15 12:42 ` Mark Cave-Ayland
1 sibling, 0 replies; 3+ messages in thread
From: Mark Cave-Ayland @ 2015-03-15 12:42 UTC (permalink / raw)
To: Richard Henderson, qemu-devel
On 13/03/15 19:26, Richard Henderson wrote:
> As seen with ubuntu-5.10-live-powerpc.iso.
>
> Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
> tcg/optimize.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index 067917c..37c1110 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -980,8 +980,11 @@ static void tcg_constant_folding(TCGContext *s)
> if (temps_are_copies(args[1], args[2])) {
> if (temps_are_copies(args[0], args[1])) {
> tcg_op_remove(s, op);
> - } else {
> + } else if (temps[args[1]].state != TCG_TEMP_CONST) {
> tcg_opt_gen_mov(s, op, args, opc, args[0], args[1]);
> + } else {
> + tcg_opt_gen_movi(s, op, args, opc,
> + args[0], temps[args[1]].val);
> }
> continue;
> }
>
Great work! Fixes the issue here for me so:
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
ATB,
Mark.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-15 12:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-13 19:26 [Qemu-devel] [PATCH] tcg/optimize: Handle or r, a, a with constant a Richard Henderson
2015-03-14 0:54 ` Bastian Koppelmann
2015-03-15 12:42 ` Mark Cave-Ayland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).