From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWhZM-0003Cl-Bn for qemu-devel@nongnu.org; Sat, 14 Mar 2015 04:37:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YWhZJ-00047U-5R for qemu-devel@nongnu.org; Sat, 14 Mar 2015 04:37:16 -0400 From: Stefan Weil Date: Sat, 14 Mar 2015 09:37:08 +0100 Message-Id: <1426322228-465-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH] elf-loader: Fix truncation warning from coverity List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Trivial Cc: Stefan Weil , QEMU Developer Coverity reports a truncation due to cast operation on operand reltab->sh_size from 64 bits to 32 bits for calls of load_at. Fix the types of the function arguments to match their use in function load_at: the offset is used for lseek which takes an off_t parameter, the size is used for g_malloc and read. Signed-off-by: Stefan Weil --- hw/core/loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 76d8aca..d4c441f 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -267,7 +267,7 @@ int load_aout(const char *filename, hwaddr addr, int max_sz, /* ELF loader */ -static void *load_at(int fd, int offset, int size) +static void *load_at(int fd, off_t offset, size_t size) { void *ptr; if (lseek(fd, offset, SEEK_SET) < 0) -- 1.7.10.4