From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXNdA-0006c7-UJ for qemu-devel@nongnu.org; Mon, 16 Mar 2015 01:32:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXNd9-0003ct-Cu for qemu-devel@nongnu.org; Mon, 16 Mar 2015 01:32:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58305) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXNd9-0003cn-4t for qemu-devel@nongnu.org; Mon, 16 Mar 2015 01:31:59 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2G5Vw9Y021155 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 16 Mar 2015 01:31:58 -0400 From: Fam Zheng Date: Mon, 16 Mar 2015 13:31:48 +0800 Message-Id: <1426483910-24597-3-git-send-email-famz@redhat.com> In-Reply-To: <1426483910-24597-1-git-send-email-famz@redhat.com> References: <1426483910-24597-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v3 2/4] exec: Protect map_client_list with mutex List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini So that accesses from multiple threads are safe. Signed-off-by: Fam Zheng --- exec.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/exec.c b/exec.c index 4080044..3e54580 100644 --- a/exec.c +++ b/exec.c @@ -429,15 +429,6 @@ address_space_translate_for_iotlb(CPUState *cpu, hwaddr addr, } #endif -void cpu_exec_init_all(void) -{ -#if !defined(CONFIG_USER_ONLY) - qemu_mutex_init(&ram_list.mutex); - memory_map_init(); - io_mem_init(); -#endif -} - #if !defined(CONFIG_USER_ONLY) static int cpu_common_post_load(void *opaque, int version_id) @@ -2494,6 +2485,7 @@ typedef struct MapClient { QLIST_ENTRY(MapClient) link; } MapClient; +QemuMutex map_client_list_lock; static QLIST_HEAD(map_client_list, MapClient) map_client_list = QLIST_HEAD_INITIALIZER(map_client_list); @@ -2501,12 +2493,24 @@ void *cpu_register_map_client(void *opaque, void (*callback)(void *opaque)) { MapClient *client = g_malloc(sizeof(*client)); + qemu_mutex_lock(&map_client_list_lock); client->opaque = opaque; client->callback = callback; QLIST_INSERT_HEAD(&map_client_list, client, link); + qemu_mutex_unlock(&map_client_list_lock); return client; } +void cpu_exec_init_all(void) +{ +#if !defined(CONFIG_USER_ONLY) + qemu_mutex_init(&ram_list.mutex); + memory_map_init(); + io_mem_init(); +#endif + qemu_mutex_init(&map_client_list_lock); +} + static void cpu_unregister_map_client(void *_client) { MapClient *client = (MapClient *)_client; @@ -2519,11 +2523,13 @@ static void cpu_notify_map_clients(void) { MapClient *client; + qemu_mutex_lock(&map_client_list_lock); while (!QLIST_EMPTY(&map_client_list)) { client = QLIST_FIRST(&map_client_list); client->callback(client->opaque); cpu_unregister_map_client(client); } + qemu_mutex_unlock(&map_client_list_lock); } bool address_space_access_valid(AddressSpace *as, hwaddr addr, int len, bool is_write) -- 1.9.3