From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: anthony@codemonkey.ws, peter.maydell@linaro.org
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Shannon Zhao <shannon.zhao@linaro.org>,
qemu-devel@nongnu.org, Shannon Zhao <zhaoshenglong@huawei.com>
Subject: [Qemu-devel] [PATCH 3/6] hw/9pfs/virtio-9p-posix-acl: Fix out-of-bounds access
Date: Mon, 16 Mar 2015 15:39:40 +0530 [thread overview]
Message-ID: <1426500583-15712-4-git-send-email-aneesh.kumar@linux.vnet.ibm.com> (raw)
In-Reply-To: <1426500583-15712-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
From: Shannon Zhao <zhaoshenglong@huawei.com>
It's detected by coverity. Fix out-of-bounds access of the function mp_dacl_listxattr.
Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
hw/9pfs/virtio-9p-posix-acl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/9pfs/virtio-9p-posix-acl.c b/hw/9pfs/virtio-9p-posix-acl.c
index 803d9d94f3b8..09dad071e487 100644
--- a/hw/9pfs/virtio-9p-posix-acl.c
+++ b/hw/9pfs/virtio-9p-posix-acl.c
@@ -114,7 +114,7 @@ static ssize_t mp_dacl_listxattr(FsContext *ctx, const char *path,
}
/* len includes the trailing NUL */
- memcpy(value, ACL_ACCESS, len);
+ memcpy(value, ACL_DEFAULT, len);
return 0;
}
--
2.1.0
next prev parent reply other threads:[~2015-03-16 10:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 10:09 [Qemu-devel] [PULL] VirtFS update Aneesh Kumar K.V
2015-03-16 10:09 ` [Qemu-devel] [PATCH 1/6] 9pfs-local: simplify/optimize local_mapped_attr_path() Aneesh Kumar K.V
2015-03-16 10:09 ` [Qemu-devel] [PATCH 2/6] 9pfs-proxy: tiny cleanups in proxy_pwritev and proxy_preadv Aneesh Kumar K.V
2015-03-16 10:09 ` Aneesh Kumar K.V [this message]
2015-03-16 10:09 ` [Qemu-devel] [PATCH 4/6] fsdev/virtfs-proxy-helper: Fix improper use of negative value Aneesh Kumar K.V
2015-03-16 10:09 ` [Qemu-devel] [PATCH 5/6] virtfs-proxy: Fix possible overflow Aneesh Kumar K.V
2015-03-16 10:09 ` [Qemu-devel] [PATCH 6/6] virtio: Fix memory leaks reported by Coverity Aneesh Kumar K.V
2015-03-16 13:55 ` [Qemu-devel] [PULL] VirtFS update Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426500583-15712-4-git-send-email-aneesh.kumar@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).