From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXRzb-0002uV-0e for qemu-devel@nongnu.org; Mon, 16 Mar 2015 06:11:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXRzV-0005ci-A7 for qemu-devel@nongnu.org; Mon, 16 Mar 2015 06:11:26 -0400 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:36944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXRzU-0005b3-MX for qemu-devel@nongnu.org; Mon, 16 Mar 2015 06:11:21 -0400 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Mar 2015 15:41:18 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 7E3F03940060 for ; Mon, 16 Mar 2015 15:41:13 +0530 (IST) Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay01.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2GAB4dr28180730 for ; Mon, 16 Mar 2015 15:41:04 +0530 Received: from d28av01.in.ibm.com (localhost [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2GAB3kV024602 for ; Mon, 16 Mar 2015 15:41:04 +0530 From: "Aneesh Kumar K.V" Date: Mon, 16 Mar 2015 15:39:41 +0530 Message-Id: <1426500583-15712-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com> In-Reply-To: <1426500583-15712-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> References: <1426500583-15712-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 4/6] fsdev/virtfs-proxy-helper: Fix improper use of negative value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws, peter.maydell@linaro.org Cc: "Aneesh Kumar K.V" , Shannon Zhao , qemu-devel@nongnu.org, Shannon Zhao From: Shannon Zhao It's detected by coverity. Check the return value of proxy_marshal. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Aneesh Kumar K.V --- fsdev/virtfs-proxy-helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c index c1da2d78e78b..bf2e5f333121 100644 --- a/fsdev/virtfs-proxy-helper.c +++ b/fsdev/virtfs-proxy-helper.c @@ -262,6 +262,9 @@ static int send_status(int sockfd, struct iovec *iovec, int status) */ msg_size = proxy_marshal(iovec, 0, "ddd", header.type, header.size, status); + if (msg_size < 0) { + return msg_size; + } retval = socket_write(sockfd, iovec->iov_base, msg_size); if (retval < 0) { return retval; -- 2.1.0