qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: [Qemu-devel] [PULL 01/11] Add -incoming defer
Date: Mon, 16 Mar 2015 14:41:02 +0100	[thread overview]
Message-ID: <1426513272-20070-2-git-send-email-quintela@redhat.com> (raw)
In-Reply-To: <1426513272-20070-1-git-send-email-quintela@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

-incoming defer causes qemu to wait for an incoming migration
to be specified later.  The monitor can be used to set migration
capabilities that may affect the incoming connection process.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 migration/migration.c | 29 +++++++++++++++++++++++------
 1 file changed, 23 insertions(+), 6 deletions(-)

diff --git a/migration/migration.c b/migration/migration.c
index b3adbc6..f3d49d5 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -49,6 +49,8 @@ enum {
 static NotifierList migration_state_notifiers =
     NOTIFIER_LIST_INITIALIZER(migration_state_notifiers);

+static bool deferred_incoming;
+
 /* When we add fault tolerance, we could have several
    migrations at once.  For now we don't need to add
    dynamic creation of migration */
@@ -65,25 +67,40 @@ MigrationState *migrate_get_current(void)
     return &current_migration;
 }

+/*
+ * Called on -incoming with a defer: uri.
+ * The migration can be started later after any parameters have been
+ * changed.
+ */
+static void deferred_incoming_migration(Error **errp)
+{
+    if (deferred_incoming) {
+        error_setg(errp, "Incoming migration already deferred");
+    }
+    deferred_incoming = true;
+}
+
 void qemu_start_incoming_migration(const char *uri, Error **errp)
 {
     const char *p;

-    if (strstart(uri, "tcp:", &p))
+    if (!strcmp(uri, "defer")) {
+        deferred_incoming_migration(errp);
+    } else if (strstart(uri, "tcp:", &p)) {
         tcp_start_incoming_migration(p, errp);
 #ifdef CONFIG_RDMA
-    else if (strstart(uri, "rdma:", &p))
+    } else if (strstart(uri, "rdma:", &p)) {
         rdma_start_incoming_migration(p, errp);
 #endif
 #if !defined(WIN32)
-    else if (strstart(uri, "exec:", &p))
+    } else if (strstart(uri, "exec:", &p)) {
         exec_start_incoming_migration(p, errp);
-    else if (strstart(uri, "unix:", &p))
+    } else if (strstart(uri, "unix:", &p)) {
         unix_start_incoming_migration(p, errp);
-    else if (strstart(uri, "fd:", &p))
+    } else if (strstart(uri, "fd:", &p)) {
         fd_start_incoming_migration(p, errp);
 #endif
-    else {
+    } else {
         error_setg(errp, "unknown migration protocol: %s", uri);
     }
 }
-- 
2.1.0

  reply	other threads:[~2015-03-16 13:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 13:41 [Qemu-devel] [PULL 00/11] Migration pull request Juan Quintela
2015-03-16 13:41 ` Juan Quintela [this message]
2015-03-16 13:41 ` [Qemu-devel] [PULL 02/11] Add migrate_incoming Juan Quintela
2015-03-16 14:35   ` Eric Blake
2015-03-16 13:41 ` [Qemu-devel] [PULL 03/11] ram: make all save_page functions take a uint64_t parameter Juan Quintela
2015-03-16 13:41 ` [Qemu-devel] [PULL 04/11] ram_find_and_save_block: change calling convention Juan Quintela
2015-03-16 13:41 ` [Qemu-devel] [PULL 05/11] ram_save_page: change calling covention Juan Quintela
2015-03-16 13:41 ` [Qemu-devel] [PULL 06/11] save_xbzrle_page: change calling convention Juan Quintela
2015-03-16 13:41 ` [Qemu-devel] [PULL 07/11] save_block_hdr: we can recalculate the cont parameter here Juan Quintela
2015-03-17  3:13   ` Li, Liang Z
2015-03-17 12:00     ` Juan Quintela
2015-03-16 13:41 ` [Qemu-devel] [PULL 08/11] rename save_block_hdr to save_page_header Juan Quintela
2015-03-16 13:41 ` [Qemu-devel] [PULL 09/11] migration: Read JSON VM description on incoming migration Juan Quintela
2015-03-16 13:41 ` [Qemu-devel] [PULL 10/11] migration: Allow to suppress vmdesc submission Juan Quintela
2015-03-16 13:41 ` [Qemu-devel] [PULL 11/11] pc: Disable vmdesc submission for old machines Juan Quintela
2015-03-16 15:55 ` [Qemu-devel] [PULL 00/11] Migration pull request Markus Armbruster
2015-03-16 16:20   ` Juan Quintela
2015-03-16 17:22 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426513272-20070-2-git-send-email-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).