From: "Gabriel L. Somlo" <somlo@cmu.edu>
To: qemu-devel@nongnu.org
Cc: matt.fleming@intel.com, rjones@redhat.com,
jordan.l.justen@intel.com, gleb@cloudius-systems.com,
mdroth@linux.vnet.ibm.com, gsomlo@gmail.com, kraxel@redhat.com,
pbonzini@redhat.com, lersek@redhat.com
Subject: [Qemu-devel] [PATCH 0/6] fw-cfg: documentation, cleanup, and proposed feature
Date: Mon, 16 Mar 2015 10:14:59 -0400 [thread overview]
Message-ID: <1426515305-17766-1-git-send-email-somlo@cmu.edu> (raw)
Document and clean up fw_cfg; additionally, allow user-provided blobs to
be inserted into fw_cfg via the qemu command line.
Please consider applying 1-5; Patch 6/6 should be considered as just an RFC
at this time, please let me know what you all think about it.
Summary of patches in the series:
1/6: resubmit Jordan's documentation patch from back in 2011
2/6: remove support for guest-side writes to fw_cfg data port
(this also updates the documentation applied earlier in 1/6)
3/6: add assertion to prevent us from inadvertently introducing memory leaks
when adding data blobs to fw_cfg
4/6: adding fw_cfg blobs with the same file name multiple times is a
memory-leaking erroneous thing to do: make qemu properly quit with
an error instead of just generating a trace event.
5/6: allow users to explicitly insert an arbitrary file as a fw_cfg blob
via the qemu command line
6/6: guest-side retrieval of named blob from the fw_cfg device
(please do NOT apply 6/6, as I'm just soliciting feedback at this time)
Thanks much,
Gabriel
Gabriel L. Somlo (6):
fw_cfg: add documentation file (docs/specs/fw_cfg.txt)
fw_cfg: remove support for guest-side data writes
fw_cfg: assertion to detect memory leak when adding new data blob
fw_cfg: exit with error when dupe fw_cfg file name inserted
fw_cfg: insert fw_cfg file blobs via qemu cmdline
qga: RFC: guest-side retrieval of fw_cfg file
docs/specs/fw_cfg.txt | 154 ++++++++++++++++++++++++++++++++++++++++++++++
hw/nvram/fw_cfg.c | 123 ++++++++++++++++++------------------
include/hw/nvram/fw_cfg.h | 8 ++-
qemu-options.hx | 10 +++
qga/Makefile.objs | 1 +
qga/get-fwcfg.c | 92 +++++++++++++++++++++++++++
qga/guest-agent-core.h | 2 +
qga/main.c | 6 +-
vl.c | 27 ++++++++
9 files changed, 355 insertions(+), 68 deletions(-)
create mode 100644 docs/specs/fw_cfg.txt
create mode 100644 qga/get-fwcfg.c
--
2.1.0
next reply other threads:[~2015-03-16 14:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 14:14 Gabriel L. Somlo [this message]
2015-03-16 14:15 ` [Qemu-devel] [PATCH 1/6] fw_cfg: add documentation file (docs/specs/fw_cfg.txt) Gabriel L. Somlo
2015-03-16 16:30 ` Laszlo Ersek
2015-03-16 14:15 ` [Qemu-devel] [PATCH 2/6] fw_cfg: remove support for guest-side data writes Gabriel L. Somlo
2015-03-16 17:02 ` Laszlo Ersek
2015-03-16 18:41 ` Gabriel L. Somlo
2015-03-17 7:46 ` Gerd Hoffmann
2015-03-16 14:15 ` [Qemu-devel] [PATCH 3/6] fw_cfg: assertion to detect memory leak when adding new data blob Gabriel L. Somlo
2015-03-16 19:12 ` Laszlo Ersek
2015-03-16 14:15 ` [Qemu-devel] [PATCH 4/6] fw_cfg: exit with error when dupe fw_cfg file name inserted Gabriel L. Somlo
2015-03-16 19:26 ` Laszlo Ersek
2015-03-16 14:15 ` [Qemu-devel] [PATCH 5/6] fw_cfg: insert fw_cfg file blobs via qemu cmdline Gabriel L. Somlo
2015-03-17 10:07 ` Gerd Hoffmann
2015-03-17 10:55 ` Matt Fleming
2015-03-17 14:09 ` Gabriel L. Somlo
2015-03-17 11:28 ` Laszlo Ersek
2015-03-17 11:49 ` Gerd Hoffmann
2015-03-18 20:06 ` Gabriel L. Somlo
2015-03-19 10:43 ` Laszlo Ersek
2015-03-18 20:27 ` Gabriel L. Somlo
2015-03-19 7:34 ` Gerd Hoffmann
2015-03-19 8:41 ` [Qemu-devel] How to emit errors with nice location information (was: [PATCH 5/6] fw_cfg: insert fw_cfg file blobs via qemu cmdline) Markus Armbruster
2015-03-16 14:15 ` [Qemu-devel] [PATCH 6/6] qga: RFC: guest-side retrieval of fw_cfg file Gabriel L. Somlo
2015-03-17 12:38 ` Laszlo Ersek
2015-03-17 14:28 ` Gabriel L. Somlo
2015-03-19 18:27 ` Kevin O'Connor
2015-03-19 18:44 ` Laszlo Ersek
2015-03-16 14:26 ` [Qemu-devel] [PATCH 0/6] fw-cfg: documentation, cleanup, and proposed feature Patchew Tool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426515305-17766-1-git-send-email-somlo@cmu.edu \
--to=somlo@cmu.edu \
--cc=gleb@cloudius-systems.com \
--cc=gsomlo@gmail.com \
--cc=jordan.l.justen@intel.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=matt.fleming@intel.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).