From: Gerd Hoffmann <kraxel@redhat.com>
To: arei.gonglei@huawei.com
Cc: qemu-stable <qemu-stable@nongnu.org>,
qemu-devel@nongnu.org, peter.huangpeng@huawei.com
Subject: Re: [Qemu-devel] [PATCH] usb: fix segfault when hot-unplugging usb host adapter
Date: Tue, 17 Mar 2015 12:58:57 +0100 [thread overview]
Message-ID: <1426593537.27188.95.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1426591711-14472-1-git-send-email-arei.gonglei@huawei.com>
> + qemu_unregister_reset(ehci_reset, s);
We should hook up reset via DeviceClass->reset then (xhci already does
it this way) and drop the qemu_register_reset() calls.
Then qemu will register and unregister the reset handler automatically
for us.
cheers,
Gerd
next prev parent reply other threads:[~2015-03-17 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 11:28 [Qemu-devel] [PATCH] usb: fix segfault when hot-unplugging usb host adapter arei.gonglei
2015-03-17 11:58 ` Gerd Hoffmann [this message]
2015-03-17 12:10 ` Gonglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426593537.27188.95.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).