From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXq9K-0007QH-33 for qemu-devel@nongnu.org; Tue, 17 Mar 2015 07:59:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXq9J-0003bM-70 for qemu-devel@nongnu.org; Tue, 17 Mar 2015 07:59:06 -0400 Message-ID: <1426593537.27188.95.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Tue, 17 Mar 2015 12:58:57 +0100 In-Reply-To: <1426591711-14472-1-git-send-email-arei.gonglei@huawei.com> References: <1426591711-14472-1-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] usb: fix segfault when hot-unplugging usb host adapter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com Cc: qemu-stable , qemu-devel@nongnu.org, peter.huangpeng@huawei.com > + qemu_unregister_reset(ehci_reset, s); We should hook up reset via DeviceClass->reset then (xhci already does it this way) and drop the qemu_register_reset() calls. Then qemu will register and unregister the reset handler automatically for us. cheers, Gerd