From: Gerd Hoffmann <kraxel@redhat.com>
To: Thomas Huth <thuth@linux.vnet.ibm.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/usb: Include USB files only if necessary
Date: Tue, 17 Mar 2015 13:19:57 +0100 [thread overview]
Message-ID: <1426594797.27188.103.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1426593930.27188.96.camel@nilsson.home.kraxel.org>
On Di, 2015-03-17 at 13:05 +0100, Gerd Hoffmann wrote:
> On Sa, 2015-03-14 at 06:33 +0100, Thomas Huth wrote:
> > Boards that do not include an USB controller should not provide
> > USB devices. However, when running "qemu-system-s390x -device help"
> > for example, there's still a usb-hub, usb-kbd, usb-mouse and
> > usb-tablet in the list of "supported" devices. Let's fix that
> > by compiling and linking the USB files only if it's really
> > necessary.
>
> Added to usb queue.
Removed, fails to build.
Needs a complete rebuild due to the new CONFIG_USB option. Hardly
avoidable I guess. But even with that done I still get this:
LINK lm32-softmmu/qemu-system-lm32
../hw/usb/redirect.o: In function `usbredir_bulk_packet':
/home/kraxel/projects/qemu/hw/usb/redirect.c:1978: undefined reference
to `usb_combined_input_packet_complete'
../hw/usb/redirect.o: In function `usbredir_flush_ep_queue':
/home/kraxel/projects/qemu/hw/usb/redirect.c:951: undefined reference to
`usb_ep_combine_input_packets'
../hw/usb/redirect.o: In function `usbredir_cancel_packet':
/home/kraxel/projects/qemu/hw/usb/redirect.c:367: undefined reference to
`usb_combined_packet_cancel'
../hw/usb/host-libusb.o: In function `usb_host_cancel_packet':
/home/kraxel/projects/qemu/hw/usb/host-libusb.c:1014: undefined
reference to `usb_combined_packet_cancel'
../hw/usb/host-libusb.o: In function `usb_host_req_complete_data':
/home/kraxel/projects/qemu/hw/usb/host-libusb.c:396: undefined reference
to `usb_combined_input_packet_complete'
../hw/usb/host-libusb.o: In function `usb_host_flush_ep_queue':
/home/kraxel/projects/qemu/hw/usb/host-libusb.c:1358: undefined
reference to `usb_ep_combine_input_packets'
collect2: error: ld returned 1 exit status
cheers,
Gerd
next prev parent reply other threads:[~2015-03-17 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-14 5:33 [Qemu-devel] [PATCH] hw/usb: Include USB files only if necessary Thomas Huth
2015-03-14 5:49 ` Thomas Huth
2015-03-17 12:05 ` Gerd Hoffmann
2015-03-17 12:19 ` Gerd Hoffmann [this message]
2015-03-17 12:40 ` Thomas Huth
2015-03-17 13:02 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426594797.27188.103.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).