From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXrm6-0000e2-Tr for qemu-devel@nongnu.org; Tue, 17 Mar 2015 09:43:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXrm2-0006Cv-Le for qemu-devel@nongnu.org; Tue, 17 Mar 2015 09:43:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXrm2-0006Cf-Gt for qemu-devel@nongnu.org; Tue, 17 Mar 2015 09:43:10 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id B19D5306025 for ; Tue, 17 Mar 2015 13:43:09 +0000 (UTC) From: "Daniel P. Berrange" Date: Tue, 17 Mar 2015 13:42:52 +0000 Message-Id: <1426599780-3264-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PATCH v2 0/8] Misc fixes for VNC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann This is a small series of fixes for the VNC server. The primary focus was on fixing the handling of TLS + auth in the websockets server so that it can actually be used in real world scenarios. These prepare the way for work I'm doing to refactor TLS handling into a module that is reusable across QEMU. Changed in v2: - Improve error reporting when VNC feature is disabled at build time - Move VNC auth scheme setup into separate method - Split the 3rd patch up into 4 pieces Daniel P. Berrange (8): ui: remove unused 'wiremode' variable in VncState struct ui: replace printf() calls with VNC_DEBUG ui: report error if user requests VNC option that is unsupported ui: split setup of VNC auth scheme into separate method ui: fix setup of VNC websockets auth scheme with TLS ui: enforce TLS when using websockets server ui: remove separate gnutls_session for websockets server ui: ensure VNC websockets server checks the ACL if requested ui/vnc-auth-vencrypt.c | 1 - ui/vnc-tls.c | 72 +++++-------- ui/vnc-tls.h | 7 -- ui/vnc-ws.c | 46 ++++---- ui/vnc-ws.h | 2 +- ui/vnc.c | 287 +++++++++++++++++++++++++++++-------------------- ui/vnc.h | 9 +- 7 files changed, 222 insertions(+), 202 deletions(-) -- 2.1.0