* [Qemu-devel] [PATCH] qtest/ahci: Fix clang 3.5.0 error
@ 2015-03-17 20:58 John Snow
2015-03-18 7:11 ` [Qemu-devel] [Qemu-block] " Markus Armbruster
2015-03-19 8:28 ` [Qemu-devel] " Michael Tokarev
0 siblings, 2 replies; 4+ messages in thread
From: John Snow @ 2015-03-17 20:58 UTC (permalink / raw)
To: qemu-block; +Cc: qemu-trivial, John Snow, qemu-devel
A thinko that clang 3.5.0 caught.
Thankfully does not introduce any new failures.
Signed-off-by: John Snow <jsnow@redhat.com>
---
tests/ahci-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index cf0b98b..169e83b 100644
--- a/tests/ahci-test.c
+++ b/tests/ahci-test.c
@@ -583,7 +583,7 @@ static void ahci_test_port_spec(AHCIQState *ahci, uint8_t port)
ASSERT_BIT_CLEAR(reg, AHCI_PX_CMD_MPSP);
}
/* If, via CPD or MPSP we detect a drive, HPCP must be on. */
- if (BITANY(reg, AHCI_PX_CMD_CPD || AHCI_PX_CMD_MPSP)) {
+ if (BITANY(reg, AHCI_PX_CMD_CPD | AHCI_PX_CMD_MPSP)) {
ASSERT_BIT_SET(reg, AHCI_PX_CMD_HPCP);
}
/* HPCP and ESP cannot both be active. */
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [Qemu-block] [PATCH] qtest/ahci: Fix clang 3.5.0 error
2015-03-17 20:58 [Qemu-devel] [PATCH] qtest/ahci: Fix clang 3.5.0 error John Snow
@ 2015-03-18 7:11 ` Markus Armbruster
2015-03-18 14:23 ` John Snow
2015-03-19 8:28 ` [Qemu-devel] " Michael Tokarev
1 sibling, 1 reply; 4+ messages in thread
From: Markus Armbruster @ 2015-03-18 7:11 UTC (permalink / raw)
To: John Snow; +Cc: qemu-trivial, qemu-devel, qemu-block
John Snow <jsnow@redhat.com> writes:
> A thinko that clang 3.5.0 caught.
> Thankfully does not introduce any new failures.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
How you caught the bug is interesting enough to be mentioned in the
commit message, but the nature of the bug surely is more interesting
than that. Suggest to change the subject to
qtest/ahci: Fix a bit mask expression
Perhaps it can be fixed up on commit.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [Qemu-block] [PATCH] qtest/ahci: Fix clang 3.5.0 error
2015-03-18 7:11 ` [Qemu-devel] [Qemu-block] " Markus Armbruster
@ 2015-03-18 14:23 ` John Snow
0 siblings, 0 replies; 4+ messages in thread
From: John Snow @ 2015-03-18 14:23 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-trivial, qemu-devel, qemu-block
On 03/18/2015 03:11 AM, Markus Armbruster wrote:
> John Snow <jsnow@redhat.com> writes:
>
>> A thinko that clang 3.5.0 caught.
>> Thankfully does not introduce any new failures.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>
> How you caught the bug is interesting enough to be mentioned in the
> commit message, but the nature of the bug surely is more interesting
> than that. Suggest to change the subject to
>
> qtest/ahci: Fix a bit mask expression
>
> Perhaps it can be fixed up on commit.
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
If it goes in through trivial,
can we change this to Markus's suggestion?
Thank you,
--js
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] qtest/ahci: Fix clang 3.5.0 error
2015-03-17 20:58 [Qemu-devel] [PATCH] qtest/ahci: Fix clang 3.5.0 error John Snow
2015-03-18 7:11 ` [Qemu-devel] [Qemu-block] " Markus Armbruster
@ 2015-03-19 8:28 ` Michael Tokarev
1 sibling, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2015-03-19 8:28 UTC (permalink / raw)
To: John Snow, qemu-block; +Cc: qemu-trivial, qemu-devel
17.03.2015 23:58, John Snow wrote:
> A thinko that clang 3.5.0 caught.
> Thankfully does not introduce any new failures.
Applied to trivial, changing subject to the one suggested by Markus.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-19 8:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-17 20:58 [Qemu-devel] [PATCH] qtest/ahci: Fix clang 3.5.0 error John Snow
2015-03-18 7:11 ` [Qemu-devel] [Qemu-block] " Markus Armbruster
2015-03-18 14:23 ` John Snow
2015-03-19 8:28 ` [Qemu-devel] " Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).