From: Tiejun Chen <tiejun.chen@intel.com>
To: mst@redhat.com, kraxel@redhat.com, pbonzini@redhat.com, rth@twiddle.net
Cc: allen.m.kay@intel.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [v7][PATCH 02/10] pc_init1: pass parameters just with types
Date: Wed, 18 Mar 2015 17:06:33 +0800 [thread overview]
Message-ID: <1426669601-13891-3-git-send-email-tiejun.chen@intel.com> (raw)
In-Reply-To: <1426669601-13891-1-git-send-email-tiejun.chen@intel.com>
Pass types to configure pc_init1().
Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
---
hw/i386/pc_piix.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 07faec9..cea3a5c 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -75,7 +75,9 @@ static bool has_reserved_memory = true;
/* PC hardware initialisation */
static void pc_init1(MachineState *machine,
int pci_enabled,
- int kvmclock_enabled)
+ int kvmclock_enabled,
+ const char *host_type,
+ const char *pci_type)
{
PCMachineState *pc_machine = PC_MACHINE(machine);
MemoryRegion *system_memory = get_system_memory();
@@ -202,8 +204,8 @@ static void pc_init1(MachineState *machine,
}
if (pci_enabled) {
- pci_bus = i440fx_init(TYPE_I440FX_PCI_HOST_BRIDGE,
- TYPE_I440FX_PCI_DEVICE,
+ pci_bus = i440fx_init(host_type,
+ pci_type,
&i440fx_state, &piix3_devfn, &isa_bus, gsi,
system_memory, system_io, machine->ram_size,
below_4g_mem_size,
@@ -309,7 +311,8 @@ static void pc_init1(MachineState *machine,
static void pc_init_pci(MachineState *machine)
{
- pc_init1(machine, 1, 1);
+ pc_init1(machine, 1, 1, TYPE_I440FX_PCI_HOST_BRIDGE,
+ TYPE_I440FX_PCI_DEVICE);
}
static void pc_compat_2_2(MachineState *machine)
@@ -478,7 +481,8 @@ static void pc_init_pci_1_2(MachineState *machine)
static void pc_init_pci_no_kvmclock(MachineState *machine)
{
pc_compat_1_2(machine);
- pc_init1(machine, 1, 0);
+ pc_init1(machine, 1, 0, TYPE_I440FX_PCI_HOST_BRIDGE,
+ TYPE_I440FX_PCI_DEVICE);
}
static void pc_init_isa(MachineState *machine)
@@ -495,7 +499,8 @@ static void pc_init_isa(MachineState *machine)
}
x86_cpu_compat_kvm_no_autoenable(FEAT_KVM, 1 << KVM_FEATURE_PV_EOI);
enable_compat_apic_id_mode();
- pc_init1(machine, 0, 1);
+ pc_init1(machine, 0, 1, TYPE_I440FX_PCI_HOST_BRIDGE,
+ TYPE_I440FX_PCI_DEVICE);
}
#ifdef CONFIG_XEN
--
1.9.1
next prev parent reply other threads:[~2015-03-18 9:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 9:06 [Qemu-devel] [v7][PATCH 00/10] xen: add Intel IGD passthrough support Tiejun Chen
2015-03-18 9:06 ` [Qemu-devel] [v7][PATCH 01/10] i440fx: make types configurable at run-time Tiejun Chen
2015-03-18 9:06 ` Tiejun Chen [this message]
2015-03-18 9:06 ` [Qemu-devel] [v7][PATCH 03/10] piix: create host bridge to passthrough Tiejun Chen
2015-03-18 10:21 ` Gerd Hoffmann
2015-03-19 1:01 ` Chen, Tiejun
2015-03-26 7:57 ` Chen, Tiejun
2015-03-26 8:15 ` Michael S. Tsirkin
2015-03-26 8:36 ` Chen, Tiejun
2015-05-20 8:17 ` Chen, Tiejun
2015-05-31 18:11 ` Michael S. Tsirkin
2015-06-02 0:50 ` Chen, Tiejun
2015-06-02 9:17 ` Michael S. Tsirkin
2015-06-05 8:36 ` Chen, Tiejun
2015-04-15 9:17 ` eraul_cn
2015-03-18 9:06 ` [Qemu-devel] [v7][PATCH 04/10] hw/pci-assign: split pci-assign.c Tiejun Chen
2015-03-18 9:06 ` [Qemu-devel] [v7][PATCH 05/10] xen, gfx passthrough: basic graphics passthrough support Tiejun Chen
2015-03-18 9:06 ` [Qemu-devel] [v7][PATCH 06/10] xen, gfx passthrough: retrieve VGA BIOS to work Tiejun Chen
2015-03-18 9:06 ` [Qemu-devel] [v7][PATCH 07/10] igd gfx passthrough: create a isa bridge Tiejun Chen
2015-03-18 9:06 ` [Qemu-devel] [v7][PATCH 08/10] xen, gfx passthrough: register " Tiejun Chen
2015-03-18 9:06 ` [Qemu-devel] [v7][PATCH 09/10] xen, gfx passthrough: register host bridge specific to passthrough Tiejun Chen
2015-03-18 9:06 ` [Qemu-devel] [v7][PATCH 10/10] xen, gfx passthrough: add opregion mapping Tiejun Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426669601-13891-3-git-send-email-tiejun.chen@intel.com \
--to=tiejun.chen@intel.com \
--cc=allen.m.kay@intel.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).