From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYC6n-00073l-5q for qemu-devel@nongnu.org; Wed, 18 Mar 2015 07:25:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYC6h-0001gn-Pc for qemu-devel@nongnu.org; Wed, 18 Mar 2015 07:25:57 -0400 Received: from mail-wg0-x22e.google.com ([2a00:1450:400c:c00::22e]:33220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYC6h-0001gc-Iq for qemu-devel@nongnu.org; Wed, 18 Mar 2015 07:25:51 -0400 Received: by wgbcc7 with SMTP id cc7so32421641wgb.0 for ; Wed, 18 Mar 2015 04:25:51 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Wed, 18 Mar 2015 12:24:48 +0100 Message-Id: <1426677906-51657-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1426677906-51657-1-git-send-email-pbonzini@redhat.com> References: <1426677906-51657-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 01/19] nbd: Fix overflow return value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Yik Fang From: Yik Fang The value of reply.error should be the type unsigned int. Signed-off-by: Yik Fang Message-Id: <1423722111-12902-1-git-send-email-eric.fangyi@huawei.com> Signed-off-by: Paolo Bonzini --- nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd.c b/nbd.c index 71159af..02ba0fe 100644 --- a/nbd.c +++ b/nbd.c @@ -1295,7 +1295,7 @@ static void nbd_trip(void *opaque) default: LOG("invalid request type (%u) received", request.type); invalid_request: - reply.error = -EINVAL; + reply.error = EINVAL; error_reply: if (nbd_co_send_reply(req, &reply, 0) < 0) { goto out; -- 2.3.0