From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Chen Fan <chen.fan.fnst@cn.fujitsu.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PULL 4/8] aer: fix wrong check on expose aer tlp prefix log
Date: Wed, 18 Mar 2015 13:34:45 +0100 [thread overview]
Message-ID: <1426682025-20844-5-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1426682025-20844-1-git-send-email-mst@redhat.com>
From: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
when specify TLP Prefix log as using pcie_aer_inject_error,
the TLP prefix log is always discarded. because the check
is incorrect, the End-End TLP Prefix Supported bit
(PCI_EXP_DEVCAP2_EETLPP) should be in Device Capabilities 2 Register.
Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/pci/pcie_aer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c
index 5a25c32..c7fad34 100644
--- a/hw/pci/pcie_aer.c
+++ b/hw/pci/pcie_aer.c
@@ -433,7 +433,7 @@ static void pcie_aer_update_log(PCIDevice *dev, const PCIEAERErr *err)
}
if ((err->flags & PCIE_AER_ERR_TLP_PREFIX_PRESENT) &&
- (pci_get_long(dev->config + dev->exp.exp_cap + PCI_EXP_DEVCTL2) &
+ (pci_get_long(dev->config + dev->exp.exp_cap + PCI_EXP_DEVCAP2) &
PCI_EXP_DEVCAP2_EETLPP)) {
for (i = 0; i < ARRAY_SIZE(err->prefix); ++i) {
/* 7.10.12 tlp prefix log register */
--
MST
next prev parent reply other threads:[~2015-03-18 12:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 12:34 [Qemu-devel] [PULL 0/8] pci, virtio bugfixes for 2.3 Michael S. Tsirkin
2015-03-18 12:34 ` [Qemu-devel] [PULL 1/8] virtio: validate the existence of handle_output before calling it Michael S. Tsirkin
2015-03-18 12:34 ` [Qemu-devel] [PULL 2/8] virtio: Fix memory leaks reported by Coverity Michael S. Tsirkin
2015-03-18 12:34 ` [Qemu-devel] [PULL 3/8] pcie: correct mistaken register bit for End-End TLP Prefix Blocking Michael S. Tsirkin
2015-03-18 12:34 ` Michael S. Tsirkin [this message]
2015-03-18 12:34 ` [Qemu-devel] [PULL 5/8] pcie_aer: fix typos in pcie_aer_inject_error comment Michael S. Tsirkin
2015-03-18 12:34 ` [Qemu-devel] [PULL 6/8] aer: fix a wrong init PCI_ERR_COR_STATUS w1cmask type register Michael S. Tsirkin
2015-03-18 12:34 ` [Qemu-devel] [PULL 7/8] pci: fix several trivial typos in comment Michael S. Tsirkin
2015-03-18 12:34 ` [Qemu-devel] [PULL 8/8] pcie_aer: fix comment to match pcie spec Michael S. Tsirkin
2015-03-19 12:08 ` [Qemu-devel] [PULL 0/8] pci, virtio bugfixes for 2.3 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426682025-20844-5-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=chen.fan.fnst@cn.fujitsu.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).