From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYDr8-0007vc-9j for qemu-devel@nongnu.org; Wed, 18 Mar 2015 09:17:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYDr5-0001vW-5G for qemu-devel@nongnu.org; Wed, 18 Mar 2015 09:17:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYDr4-0001vG-Rk for qemu-devel@nongnu.org; Wed, 18 Mar 2015 09:17:51 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 73D9B322DB5 for ; Wed, 18 Mar 2015 13:17:50 +0000 (UTC) From: Gerd Hoffmann Date: Wed, 18 Mar 2015 14:17:38 +0100 Message-Id: <1426684666-30629-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1426684666-30629-1-git-send-email-kraxel@redhat.com> References: <1426684666-30629-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 1/9] vnc: Fix QMP change not to use funky error class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Markus Armbruster , Gerd Hoffmann From: Markus Armbruster Error classes are a leftover from the days of "rich" error objects. New code should always use ERROR_CLASS_GENERIC_ERROR. Commit 1d0d59f added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index 6f9b718..a950016 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3594,7 +3594,7 @@ void vnc_display_open(const char *id, Error **errp) dev = qdev_find_recursive(sysbus_get_default(), device_id); if (dev == NULL) { - error_set(errp, QERR_DEVICE_NOT_FOUND, device_id); + error_setg(errp, "Device '%s' not found", device_id); goto fail; } -- 1.8.3.1