From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYFwv-0003jx-9y for qemu-devel@nongnu.org; Wed, 18 Mar 2015 11:32:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYFws-0007ze-0F for qemu-devel@nongnu.org; Wed, 18 Mar 2015 11:32:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYFwr-0007zS-Nq for qemu-devel@nongnu.org; Wed, 18 Mar 2015 11:31:57 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2IFVudJ029140 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 18 Mar 2015 11:31:57 -0400 Message-ID: <1426692713.330.15.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Wed, 18 Mar 2015 16:31:53 +0100 In-Reply-To: <20150318152735-mutt-send-email-mst@redhat.com> References: <1426687214-31206-1-git-send-email-kraxel@redhat.com> <1426687214-31206-3-git-send-email-kraxel@redhat.com> <20150318152735-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On Mi, 2015-03-18 at 15:31 +0100, Michael S. Tsirkin wrote: > On Wed, Mar 18, 2015 at 03:00:12PM +0100, Gerd Hoffmann wrote: > > This patch adds virtio-input support to qemu. It brings a abstract > > base class providing core support, other classes can build on it to > > actually implement input devices. > > > > virtio-input basically sends linux input layer events (evdev) over > > virtio. > > > > Signed-off-by: Gerd Hoffmann > > Two questions before I looked at code: > - can you do a writeup for the virtio spec? > might make it easier to review. >>From cover letter: Guest driver: https://www.kraxel.org/cgit/linux/log/?h=virtio-input Specification: https://www.kraxel.org/cgit/virtio-spec/log/?h=virtio-input https://www.kraxel.org/virtio/virtio-v1.0-csprd03-virtio-input.html#x1-2640007 Guess you havn't seen that (yet) because get_maintainers.pl doesn't really work for the cover letter, only the patches, and I forgot to cc you for the whole series. [ anyone has a solution for this btw? ] > - does linux need to support this? For pass-through (patch 4) yes, emulated hid devices (patch 3) not really. It is linux only for now because the code simply #includes the system header files for the linux input layer, so it wouldn't compile on something else. > if yes we'll eventually want to take > the header from there. Yes, we can do that, for both linux input layer and virtio-input (once merged upstream) headers, then go build this on non-linux hosts too. I'd suggest to do that as incremental patch, after guest driver merge. > maybe split out guest/host ABI? When copying over virtio-input header from linux kernel that needs to happen anyway. > also might be a good idea to make style there > linux-compliant (e.g. no typedefs, add typedefs > in another header). Linux driver linked above already has that. cheers, Gerd