From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYMh0-0007GS-9P for qemu-devel@nongnu.org; Wed, 18 Mar 2015 18:44:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYMgu-0004Mf-Hs for qemu-devel@nongnu.org; Wed, 18 Mar 2015 18:44:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYMgu-0004MD-9j for qemu-devel@nongnu.org; Wed, 18 Mar 2015 18:43:56 -0400 From: John Snow Date: Wed, 18 Mar 2015 18:43:44 -0400 Message-Id: <1426718625-24120-4-git-send-email-jsnow@redhat.com> In-Reply-To: <1426718625-24120-1-git-send-email-jsnow@redhat.com> References: <1426718625-24120-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PATCH v2 3/4] configure: silence glib unknown attribute __alloc_size__ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, John Snow , stefanha@redhat.com, kbastian@mail.uni-paderborn.de v2: We must test compilation with the right glib flags, otherwise the test compile will always fail. In addition, test-compile the warning flag to make sure we can use it. The glib headers use GCC attributes. Unfortunately the __GNUC__ and __GNUC_MINOR__ version macros are also defined by clang, but clang doesn't support the same attributes as GCC. clang 3.5.0 does not support the __alloc_size__ attribute: https://github.com/llvm-mirror/clang/commit/c047507a9a79e89fc8339e074fa72822a7e7ea73 The following warning is produced: gstrfuncs.h:257:44: warning: unknown attribute '__alloc_size__' ignored [-Wunknown-attributes] G_GNUC_MALLOC G_GNUC_ALLOC_SIZE(2); gmacros.h:67:45: note: expanded from macro 'G_GNUC_ALLOC_SIZE' #define G_GNUC_ALLOC_SIZE(x) __attribute__((__alloc_size__(x))) This patch checks whether glib headers cause warnings and disables -Wunknown-attributes if that is the case. Signed-off-by: Stefan Hajnoczi Signed-off-by: John Snow --- configure | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/configure b/configure index 062df84..9db53ba 100755 --- a/configure +++ b/configure @@ -2784,6 +2784,21 @@ if ! $pkg_config --atleast-version=2.38 glib-2.0; then glib_subprocess=no fi +# Silence clang 3.5.0 warnings about glib attribute __alloc_size__ usage +cat > $TMPC << EOF +#include +int main(void) { return 0; } +EOF +if ! compile_prog "$glib_cflags -Werror" "$glib_libs" ; then + cat > $TMPC << EOF + int main(void) { return 0; } +EOF + if compile_prog "-Werror -Wunknown-attributes" ""; then + glib_cflags="-Wno-unknown-attributes $glib_cflags" + CFLAGS="-Wno-unknown-attributes $CFLAGS" + fi +fi + ########################################## # SHA command probe for modules if test "$modules" = yes; then -- 2.1.0