From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYa0j-0007yV-Eu for qemu-devel@nongnu.org; Thu, 19 Mar 2015 08:57:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYa0g-0002Xw-Jk for qemu-devel@nongnu.org; Thu, 19 Mar 2015 08:57:17 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:26393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYa0g-0002Xd-EE for qemu-devel@nongnu.org; Thu, 19 Mar 2015 08:57:14 -0400 Message-ID: <1426769810.610.64.camel@citrix.com> From: Ian Campbell Date: Thu, 19 Mar 2015 12:56:50 +0000 In-Reply-To: <1425989764-2926-2-git-send-email-quan.xu@intel.com> References: <1425989764-2926-1-git-send-email-quan.xu@intel.com> <1425989764-2926-2-git-send-email-quan.xu@intel.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Quan Xu Cc: kevin@koconnor.net, xen-devel@lists.xen.org, qemu-devel@nongnu.org, stefano.stabellini@eu.citrix.com, stefanb@linux.vnet.ibm.com On Tue, 2015-03-10 at 08:16 -0400, Quan Xu wrote: > @@ -151,6 +152,8 @@ device_hardware_setup(void) > esp_scsi_setup(); > megasas_setup(); > pvscsi_setup(); > + if (runningOnXen()) > + vtpm4hvm_setup(); Is there anything which is actually Xen specific about the driver in tpm.[ch]? Would it be better to just probe for it, perhaps gates by a Kconfig option which enables TPM support. And following that train of thought I think you could reasonable drop "4hvm" from the name. And possibly even the leading "v", since I suppose seabios shouldn't really care if the tpm is emulated or real so long as it looks like a real tpm. Ian.