From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40823)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YYbbH-0001vr-DX
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 10:39:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YYbbE-0002aC-6g
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 10:39:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50809)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YYbbD-0002a7-W6
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 10:39:04 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2JEd2dE006492
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Thu, 19 Mar 2015 10:39:02 -0400
Message-ID: <1426775939.10990.5.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 19 Mar 2015 15:38:59 +0100
In-Reply-To: <20150319123537-mutt-send-email-mst@redhat.com>
References: <1426687214-31206-1-git-send-email-kraxel@redhat.com>
	<1426687214-31206-3-git-send-email-kraxel@redhat.com>
	<20150318152735-mutt-send-email-mst@redhat.com>
	<1426692713.330.15.camel@nilsson.home.kraxel.org>
	<20150318174504-mutt-send-email-mst@redhat.com>
	<1426751129.18873.16.camel@nilsson.home.kraxel.org>
	<20150319102317-mutt-send-email-mst@redhat.com>
	<1426764781.18873.41.camel@nilsson.home.kraxel.org>
	<20150319123537-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On Do, 2015-03-19 at 12:37 +0100, Michael S. Tsirkin wrote:
> On Thu, Mar 19, 2015 at 12:33:01PM +0100, Gerd Hoffmann wrote:
> >   Hi,
> > 
> > > > Adding not-yet upstream files to the list of headers to sync over from
> > > > linux isn't sane IMHO.
> > > > 
> > > > cheers,
> > > >   Gerd
> > > > 
> > > 
> > > Of course it isn't. But you can sync it manually. Once it's upstream,
> > > add it to list for automated sync.
> > 
> > Hmm, well, not that simple, there is no whitelist for virtio headers but
> > a "*virtio*.h" glob.  So it'll simply sync automatic once landed
> > upstream, and may get deleted by accident before.
> 
> Well no - by design we only update headers, never delete them.

Hmm?

I'm talking about scripts/update-linux-headers.sh in the qemu tree.
That does a "rm -rf" followed by copying over the bits from linux
kernel.  So when switching from my virtio-input branch back to master
(in the linux kernel source tree) and re-running the script the header
file will disappear ...

Sounds like you are talking about something completely different.

cheers,
  Gerd