From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYfjF-0002hX-0w for qemu-devel@nongnu.org; Thu, 19 Mar 2015 15:03:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYfj9-0005yR-DZ for qemu-devel@nongnu.org; Thu, 19 Mar 2015 15:03:36 -0400 From: Max Reitz Date: Thu, 19 Mar 2015 15:03:18 -0400 Message-Id: <1426791801-9042-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v2 0/3] block: Warn about usage of growing formats over non-growable protocols List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz Some image formats (e.g. qcow2) require the underlying file to grow on write accesses, but this is in fact not supported by all protocols (e.g. nbd does not). If such a format requiring file growth is used non-read-only over a protocol which does not support this, a warning should be issued. This warning is issued for example whenever one tries to export a qcow2 image over nbd-server and use the export from qemu. This series depends on v2 of my series "block: driver should override flags in bdrv_open()". v2: Reworked because BDS.growable has been removed in the meantime, so this version does not need to reuse it and thus break its intended use. Max Reitz (3): iotests: Make nested read in 072 and 089 read-only block: Introduce BDS.growing block: Introduce BlockDriver.requires_growing_file block.c | 20 ++++++++++++++++++++ block/blkdebug.c | 2 ++ block/blkverify.c | 2 ++ block/iscsi.c | 2 ++ block/nbd.c | 2 ++ block/qcow.c | 1 + block/qcow2.c | 7 +++++++ block/qed.c | 1 + block/quorum.c | 5 +++++ block/raw_bsd.c | 1 + block/vdi.c | 2 ++ block/vhdx.c | 2 ++ block/vmdk.c | 1 + block/vpc.c | 2 ++ include/block/block_int.h | 7 +++++++ tests/qemu-iotests/072 | 2 +- tests/qemu-iotests/089 | 2 +- 17 files changed, 59 insertions(+), 2 deletions(-) -- 2.1.0