From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYkjk-0001ZZ-TB for qemu-devel@nongnu.org; Thu, 19 Mar 2015 20:24:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYkjk-0004WV-2N for qemu-devel@nongnu.org; Thu, 19 Mar 2015 20:24:28 -0400 From: John Snow Date: Thu, 19 Mar 2015 20:24:13 -0400 Message-Id: <1426811056-2202-2-git-send-email-jsnow@redhat.com> In-Reply-To: <1426811056-2202-1-git-send-email-jsnow@redhat.com> References: <1426811056-2202-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PATCH for-2.3 1/4] ide: fix cmd_write_pio when nsectors > 1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: pbonzini@redhat.com, John Snow , afaerber@suse.de, stefanha@redhat.com, qemu-devel@nongnu.org We need to adjust the sector being written to prior to calling ide_transfer_start, otherwise we'll write to the same sector again. Signed-off-by: John Snow --- hw/ide/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index ef52f35..0e9da64 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -846,6 +846,7 @@ static void ide_sector_write_cb(void *opaque, int ret) s->nsector -= n; s->io_buffer_offset += 512 * n; + ide_set_sector(s, ide_get_sector(s) + n); if (s->nsector == 0) { /* no more sectors to write */ ide_transfer_stop(s); @@ -857,7 +858,6 @@ static void ide_sector_write_cb(void *opaque, int ret) ide_transfer_start(s, s->io_buffer, n1 * BDRV_SECTOR_SIZE, ide_sector_write); } - ide_set_sector(s, ide_get_sector(s) + n); if (win2k_install_hack && ((++s->irq_count % 16) == 0)) { /* It seems there is a bug in the Windows 2000 installer HDD -- 2.1.0