From: David Gibson <david@gibson.dropbear.id.au>
To: rjones@redhat.com
Cc: qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org, agraf@suse.de, mst@redhat.com
Subject: [Qemu-devel] [PATCH 1/2] i6300esb: Correct endiannness
Date: Fri, 20 Mar 2015 14:11:55 +1100 [thread overview]
Message-ID: <1426821116-16617-2-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1426821116-16617-1-git-send-email-david@gibson.dropbear.id.au>
The IO operations for the i6300esb watchdog timer are marked as
DEVICE_NATIVE_ENDIAN. This is not correct, and - as a PCI device - should
be DEVICE_LITTLE_ENDIAN.
This allows i6300esb to work on ppc targets (yes, using an Intel ICH
derived device on ppc is a bit odd, but the driver exists on the guest
and there's no more obviously suitable watchdog device).
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/watchdog/wdt_i6300esb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c
index b2d158f..e694fa9 100644
--- a/hw/watchdog/wdt_i6300esb.c
+++ b/hw/watchdog/wdt_i6300esb.c
@@ -369,7 +369,7 @@ static const MemoryRegionOps i6300esb_ops = {
i6300esb_mem_writel,
},
},
- .endianness = DEVICE_NATIVE_ENDIAN,
+ .endianness = DEVICE_LITTLE_ENDIAN,
};
static const VMStateDescription vmstate_i6300esb = {
--
2.1.0
next prev parent reply other threads:[~2015-03-20 3:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 3:11 [Qemu-devel] [PATCH 0/2] Fix bugs in i6300esb watchdog timer David Gibson
2015-03-20 3:11 ` David Gibson [this message]
2015-03-20 8:54 ` [Qemu-devel] [PATCH 1/2] i6300esb: Correct endiannness Richard W.M. Jones
2015-03-20 3:11 ` [Qemu-devel] [PATCH 2/2] i6300esb: Fix signed integer overflow David Gibson
2015-03-20 8:45 ` Richard W.M. Jones
2015-03-20 9:13 ` Paolo Bonzini
2015-03-23 0:18 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426821116-16617-2-git-send-email-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).