From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYnL8-0003Ma-GK for qemu-devel@nongnu.org; Thu, 19 Mar 2015 23:11:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYnL4-0001MO-2I for qemu-devel@nongnu.org; Thu, 19 Mar 2015 23:11:14 -0400 From: David Gibson Date: Fri, 20 Mar 2015 14:11:55 +1100 Message-Id: <1426821116-16617-2-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1426821116-16617-1-git-send-email-david@gibson.dropbear.id.au> References: <1426821116-16617-1-git-send-email-david@gibson.dropbear.id.au> Subject: [Qemu-devel] [PATCH 1/2] i6300esb: Correct endiannness List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: rjones@redhat.com Cc: qemu-devel@nongnu.org, David Gibson , qemu-ppc@nongnu.org, agraf@suse.de, mst@redhat.com The IO operations for the i6300esb watchdog timer are marked as DEVICE_NATIVE_ENDIAN. This is not correct, and - as a PCI device - should be DEVICE_LITTLE_ENDIAN. This allows i6300esb to work on ppc targets (yes, using an Intel ICH derived device on ppc is a bit odd, but the driver exists on the guest and there's no more obviously suitable watchdog device). Signed-off-by: David Gibson --- hw/watchdog/wdt_i6300esb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c index b2d158f..e694fa9 100644 --- a/hw/watchdog/wdt_i6300esb.c +++ b/hw/watchdog/wdt_i6300esb.c @@ -369,7 +369,7 @@ static const MemoryRegionOps i6300esb_ops = { i6300esb_mem_writel, }, }, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static const VMStateDescription vmstate_i6300esb = { -- 2.1.0