From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH for 2.3 1/2] virtio-net: validate backend queue numbers against bus limitation
Date: Fri, 20 Mar 2015 13:52:08 +0800 [thread overview]
Message-ID: <1426830728.5879.4@smtp.corp.redhat.com> (raw)
In-Reply-To: <20150319110935-mutt-send-email-mst@redhat.com>
On Thu, Mar 19, 2015 at 6:10 PM, Michael S. Tsirkin <mst@redhat.com>
wrote:
> On Thu, Mar 19, 2015 at 03:05:51PM +0800, Jason Wang wrote:
>> We don't validate the backend queue numbers against bus limitation,
>> this will easily crash qemu if it exceeds the limitation. Fixing
>> this
>> by doing the validation and fail early.
>
> Can you please include the qemu command line that crashes?
Ok, will include it in v2. cli is something like:
qemu-system-x86_64 -netdev tap,id=hn0,queues=256 -device
virtio-net-pci,netdev=hn0 -enable-kvm
prev parent reply other threads:[~2015-03-20 5:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 7:05 [Qemu-devel] [PATCH for 2.3 1/2] virtio-net: validate backend queue numbers against bus limitation Jason Wang
2015-03-19 7:05 ` [Qemu-devel] [PATCH for 2.3 2/2] virtio-net: fix the upper bound when trying to delete queues Jason Wang
2015-03-19 10:12 ` Michael S. Tsirkin
2015-03-20 5:53 ` Jason Wang
2015-03-20 6:04 ` Jason Wang
2015-03-19 10:10 ` [Qemu-devel] [PATCH for 2.3 1/2] virtio-net: validate backend queue numbers against bus limitation Michael S. Tsirkin
2015-03-20 5:52 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426830728.5879.4@smtp.corp.redhat.com \
--to=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).