From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYprW-00038a-Ut for qemu-devel@nongnu.org; Fri, 20 Mar 2015 01:52:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYprO-0004q9-4f for qemu-devel@nongnu.org; Fri, 20 Mar 2015 01:52:50 -0400 Date: Fri, 20 Mar 2015 13:52:08 +0800 From: Jason Wang Message-Id: <1426830728.5879.4@smtp.corp.redhat.com> In-Reply-To: <20150319110935-mutt-send-email-mst@redhat.com> References: <1426748752-13385-1-git-send-email-jasowang@redhat.com> <20150319110935-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Subject: Re: [Qemu-devel] [PATCH for 2.3 1/2] virtio-net: validate backend queue numbers against bus limitation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, qemu-stable On Thu, Mar 19, 2015 at 6:10 PM, Michael S. Tsirkin wrote: > On Thu, Mar 19, 2015 at 03:05:51PM +0800, Jason Wang wrote: >> We don't validate the backend queue numbers against bus limitation, >> this will easily crash qemu if it exceeds the limitation. Fixing >> this >> by doing the validation and fail early. > > Can you please include the qemu command line that crashes? Ok, will include it in v2. cli is something like: qemu-system-x86_64 -netdev tap,id=hn0,queues=256 -device virtio-net-pci,netdev=hn0 -enable-kvm