From: Ian Campbell <ian.campbell@citrix.com>
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: Ian.Jackson@eu.citrix.com, wei.liu2@citrix.com,
qemu-devel@nongnu.org, stefano.stabellini@citrix.com,
xen-devel@lists.xen.org
Subject: Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind
Date: Fri, 20 Mar 2015 10:11:45 +0000 [thread overview]
Message-ID: <1426846305.21742.116.camel@citrix.com> (raw)
In-Reply-To: <550BF188.20401@intel.com>
On Fri, 2015-03-20 at 18:08 +0800, Chen, Tiejun wrote:
> + if (!xlu_cfg_get_string(config, "gfx_passthru_kind", &buf, 0)) {
> + if (libxl_gfx_passthru_kind_from_string(buf,
> +
> &b_info->u.hvm.gfx_passthru_kind)) {
> + fprintf(stderr,
> + "ERROR: invalid value \"%s\" for
> \"gfx_passthru_kind\"\n",
> + buf);
> + exit (1);
> + }
> + }
This unnecessary bit seems to have crept back in.
Don't forget to update the manpages if you haven't already.
next prev parent reply other threads:[~2015-03-20 10:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 9:42 [Qemu-devel] [v2][PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream Tiejun Chen
2015-03-10 9:42 ` [Qemu-devel] [v2][PATCH 1/2] libxl: introduce libxl__is_igd_vga_passthru Tiejun Chen
2015-03-11 11:26 ` Ian Campbell
2015-03-10 9:42 ` [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind Tiejun Chen
2015-03-11 11:34 ` Ian Campbell
2015-03-12 3:18 ` Chen, Tiejun
2015-03-12 12:26 ` Ian Campbell
2015-03-13 1:39 ` Chen, Tiejun
2015-03-13 10:11 ` Ian Campbell
2015-03-16 1:07 ` Chen, Tiejun
2015-03-16 12:20 ` Ian Campbell
2015-03-17 7:46 ` Chen, Tiejun
2015-03-17 9:26 ` Ian Campbell
2015-03-18 7:32 ` Chen, Tiejun
2015-03-18 10:25 ` Ian Campbell
2015-03-19 2:07 ` Chen, Tiejun
2015-03-19 10:44 ` Ian Campbell
2015-03-20 1:04 ` Chen, Tiejun
2015-03-20 9:40 ` Ian Campbell
2015-03-20 10:08 ` Chen, Tiejun
2015-03-20 10:11 ` Ian Campbell [this message]
2015-03-20 10:20 ` Chen, Tiejun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426846305.21742.116.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@citrix.com \
--cc=tiejun.chen@intel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).