qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To: "bibo mao" <bibo.mao@gmail.com>
Cc: "Bibo Mao" <maobibo@loongson.cn>,
	"Song Gao" <gaosong@loongson.cn>,
	"Huacai Chen" <chenhuacai@kernel.org>,
	"QEMU devel" <qemu-devel@nongnu.org>,
	"Xianglai Li" <lixianglai@loongson.cn>
Subject: Re: [PATCH 03/15] hw/intc/loongarch_extioi: Add irqchip-in-kernel save/restore function
Date: Mon, 19 May 2025 17:41:19 +0100	[thread overview]
Message-ID: <1426cff7-28d2-4c40-b41f-194267d1717c@app.fastmail.com> (raw)
In-Reply-To: <CAPpFdZ0NMe56bZMj=akJNaFJEjBpx4W_3Uyzr=6j-3moDWOaDw@mail.gmail.com>



在2025年5月19日周一 下午2:24,bibo mao写道:
[...]
>> I don't think there is any disadvantage. I don't really buy the "different machine"
>> justification you made. Paravirt solution tends to have its own behaviour and I don't
>> think it's a bad thing to expose it to users.
> irqchip-in-kernel is some kind of optimization, register layout and
> function is the same whatever it is
> emulated in kernel or user mode.

I can already observe some differences, for example with in-kernel irqchip
PCH MSI can be delivered to any EXTIOI vector while in user space it's only
possible to do so for 64+ vector.

I'm also planning to bring user space EXTIOI emulation closer to hardware,
as I found many issues when I was trying to bring up SylixOS BSP in QEMU,
and it's unlikely in-kernel one will follow due to performance considerations.

>
> The same for cpu type, do you think that cpu type la464 should be
> named as la464-kvm in
> KVM mode? Or you do not care about name at all?
            ^ 

I do think it for user interface it should be "host" or "max" whenever
possible in KVM mode. From QOM perspective, TCG vs KVM is handled by
TYPE_ACCEL_OPS, this makes clear distinctions at higher level.

Also, EXTIOI device is not user creatable, QOM tree information is a deep
internal detail. I searched mailing list and gitlab issues and I was unable to
find any user reports about "qom tree information confused users", given that
other architectures had taken this approach for a while.

QOM is severing QEMU's internal design, not vice versa.

Thanks
-- 
- Jiaxun


  reply	other threads:[~2025-05-19 16:42 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-09 10:07 [PATCH 00/15] hw/loongarch/virt: Add kvm_irqchip_in_kernel support Bibo Mao
2025-05-09 10:07 ` [PATCH 01/15] hw/intc/loongarch_extioi: Add irqchip-in-kernel property Bibo Mao
2025-05-09 10:07 ` [PATCH 02/15] hw/intc/loongarch_extioi: Add irqchip-in-kernel realize function Bibo Mao
2025-05-09 10:07 ` [PATCH 03/15] hw/intc/loongarch_extioi: Add irqchip-in-kernel save/restore function Bibo Mao
2025-05-09 12:36   ` Jiaxun Yang
2025-05-19  2:56     ` Bibo Mao
2025-05-19  6:50       ` Jiaxun Yang
2025-05-19  7:09         ` Bibo Mao
2025-05-19  8:49           ` Jiaxun Yang
2025-05-19  8:55             ` Bibo Mao
2025-05-19  9:15               ` Jiaxun Yang
2025-05-19 13:24                 ` bibo mao
2025-05-19 16:41                   ` Jiaxun Yang [this message]
2025-05-09 10:07 ` [PATCH 04/15] hw/intc/loongarch_ipi: Add irqchip-in-kernel property Bibo Mao
2025-05-09 10:07 ` [PATCH 05/15] hw/intc/loongarch_ipi: Add irqchip-in-kernel realize function Bibo Mao
2025-05-09 10:07 ` [PATCH 06/15] hw/intc/loongson_ipi: Add load and save interface with ipi_common class Bibo Mao
2025-05-09 10:07 ` [PATCH 07/15] hw/intc/loongarch_ipi: Add irqchip-in-kernel save/restore function Bibo Mao
2025-05-09 10:07 ` [PATCH 08/15] hw/intc/loongarch_pch_msi: Add irqchip-in-kernel property Bibo Mao
2025-05-09 10:07 ` [PATCH 09/15] hw/intc/loongarch_pch_msi: Inject MSI interrupt to kernel Bibo Mao
2025-05-09 10:07 ` [PATCH 10/15] hw/intc/loongarch_pch: Add irqchip-in-kernel property Bibo Mao
2025-05-09 10:12 ` [PATCH 11/15] hw/intc/loongarch_pch: Add irqchip-in-kernel realize function Bibo Mao
2025-05-09 10:12   ` [PATCH 12/15] hw/intc/loongarch_pch: Add irqchip-in-kernel save/restore function Bibo Mao
2025-05-09 10:12   ` [PATCH 13/15] hw/intc/loongarch_pch: Inject irq line interrupt to kernel Bibo Mao
2025-05-09 10:12   ` [PATCH 14/15] target/loongarch: Report error with split kernel_irqchip option Bibo Mao
2025-05-09 12:14     ` Jiaxun Yang
2025-05-19  2:49       ` Bibo Mao
2025-05-09 10:12   ` [PATCH 15/15] hw/loongarch/virt: Add kvm_irqchip_in_kernel support Bibo Mao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426cff7-28d2-4c40-b41f-194267d1717c@app.fastmail.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=bibo.mao@gmail.com \
    --cc=chenhuacai@kernel.org \
    --cc=gaosong@loongson.cn \
    --cc=lixianglai@loongson.cn \
    --cc=maobibo@loongson.cn \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).